From: Andi Kleen <ak@suse.de>
To: Chandramouli Narayanan <mouli@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 2.6.21 2/3] x86_64: EFI64 support
Date: Wed, 2 May 2007 22:55:37 +0200 [thread overview]
Message-ID: <200705022255.37791.ak@suse.de> (raw)
In-Reply-To: <20070501190110.958988000@em64tdvp.jf.intel.com>
> if (type && ei->type != type)
> @@ -148,6 +178,29 @@ int __init e820_all_mapped(unsigned long
> unsigned long __init find_e820_area(unsigned long start, unsigned long end, unsigned size)
> {
> int i;
> + if (efi_enabled) {
> + efi_memory_desc_t *md;
Please convert the memory map from EFI into the e820 map in one place. This
would avoid all these weird special cases. Also custom memory map would
just work then.
I know i386 doesn't do it this way, but it's wrong and we'll eventually
fix it there too.
Also you have a few arbitary and white space changes in there that should be removed.
-Andi
next prev parent reply other threads:[~2007-05-02 22:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 18:59 [PATCH 2.6.21 0/3] x86_64: EFI64 support Chandramouli Narayanan
2007-05-01 18:59 ` [PATCH 2.6.21 1/3] " Chandramouli Narayanan
2007-05-03 2:56 ` Randy Dunlap
2007-05-03 19:20 ` chandramouli narayanan
2007-05-03 20:15 ` Randy Dunlap
2007-06-01 16:47 ` Yinghai Lu
2007-05-04 13:01 ` Andi Kleen
2007-05-25 22:46 ` chandramouli narayanan
2007-06-01 18:39 ` Eric W. Biederman
2007-06-01 18:44 ` Eric W. Biederman
2007-05-01 18:59 ` [PATCH 2.6.21 2/3] " Chandramouli Narayanan
2007-05-02 20:55 ` Andi Kleen [this message]
2007-05-02 22:43 ` chandramouli narayanan
2007-06-01 18:50 ` Eric W. Biederman
2007-05-01 18:59 ` [PATCH 2.6.21 3/3] " Chandramouli Narayanan
2007-06-01 18:52 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705022255.37791.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mouli@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox