Re: [PATCH -v2 1/1] Misc: add sensable phantom driver

Jiri Slaby
2007-05-03T14:42:13Z

Andrew Morton napsal(a):
>> +static int phantom_ioctl(struct inode *inode, struct file *file, u_int cmd,
>> + u_long arg)
>
> Could we please use standard-looking types in this driver? u32 and u64 and
> things?
>
> However in this case, as it's an ioctl handler it should be "int" and
> "unsigned long".

actually, according to file_operations struct:

int (*ioctl) (struct inode *, struct file *, unsigned int, unsigned long);

"*unsigned* int" and "unsigned long" are correct types...

regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E