From: Adrian Bunk <bunk@stusta.de>
To: David Rientjes <rientjes@google.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 01/10] compiler: define __attribute_unused__
Date: Thu, 3 May 2007 19:51:26 +0200 [thread overview]
Message-ID: <20070503175125.GL3531@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0705021014070.3033@chino.kir.corp.google.com>
On Wed, May 02, 2007 at 10:16:15AM -0700, David Rientjes wrote:
> On Wed, 2 May 2007, Adrian Bunk wrote:
>
> > If we don't want any warnings with CONFIG_PCI=n, CONFIG_SYSFS=n or
> > CONFIG_PROC_FS=n, we'd have to annotate _many_ functions.
> >
> > If the lonterm goal is to compile the kernel with -Werror then we need
> > -Wno-unused-function, not annotating individual functions.
>
> That's only addressing part of the issue. What about automatic or static
> external variables that are declared but may go unreferenced depending on
This is only about static code. For non-static code it would be
impossible for gcc to issue warnings.
> preprocessor macros? You need to annotate them with __attribute__
> ((unused)) to suppress compiler warnings. Globally disabling such
> warnings would eventually cause unused code to go unnoticed.
But looking at a kernel build it seems there are far few warnings than I
remembered, so it might actually be possible to annotate all code
accordingly.
> David
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2007-05-03 17:51 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 4:28 [patch 01/10] compiler: define __attribute_unused__ David Rientjes
2007-05-02 4:28 ` [patch 02/10] i386 pci: type may be unused David Rientjes
2007-05-02 4:28 ` [patch 03/10] sh: dma: use __attribute_unused__ David Rientjes
2007-05-02 4:28 ` [patch 04/10] scsi: fix ambiguous gdthtable definition David Rientjes
2007-05-02 4:28 ` [patch 05/10] frv: gdb: use __attribute_unused__ David Rientjes
2007-05-02 4:28 ` [patch 06/10] i386: voyager: " David Rientjes
2007-05-02 4:28 ` [patch 07/10] mips: excite: " David Rientjes
2007-05-02 4:28 ` [patch 08/10] mips: tlbex: " David Rientjes
2007-05-02 4:28 ` [patch 09/10] powerpc: ps3: " David Rientjes
2007-05-02 4:28 ` [patch 10/10] i386 mmzone: " David Rientjes
2007-05-02 15:42 ` [patch 09/10] powerpc: ps3: " Geoff Levand
2007-05-03 17:23 ` [patch 08/10] mips: tlbex: " Ralf Baechle
2007-05-03 17:23 ` [patch 07/10] mips: excite: " Ralf Baechle
2007-05-07 1:28 ` [patch 03/10] sh: dma: " Paul Mundt
2007-05-02 10:35 ` [patch 02/10] i386 pci: type may be unused Andi Kleen
2007-05-02 17:05 ` David Rientjes
2007-05-02 5:17 ` [patch 01/10] compiler: define __attribute_unused__ Alexey Dobriyan
2007-05-02 5:53 ` David Rientjes
2007-05-02 6:08 ` Andrew Morton
2007-05-02 6:46 ` Nick Piggin
2007-05-02 6:33 ` WANG Cong
2007-05-02 7:02 ` Robert P. J. Day
2007-05-02 7:17 ` David Rientjes
2007-05-02 7:47 ` Robert P. J. Day
2007-05-02 5:40 ` Rusty Russell
2007-05-02 6:06 ` David Rientjes
2007-05-02 6:25 ` David Rientjes
2007-05-02 6:29 ` Rusty Russell
2007-05-02 6:41 ` David Rientjes
2007-05-02 6:52 ` Andrew Morton
2007-05-02 7:04 ` Rusty Russell
2007-05-02 7:22 ` David Rientjes
2007-05-02 7:51 ` Rusty Russell
2007-05-02 14:55 ` Adrian Bunk
2007-05-02 15:05 ` Adrian Bunk
2007-05-02 17:16 ` David Rientjes
2007-05-03 17:51 ` Adrian Bunk [this message]
2007-05-03 18:56 ` David Rientjes
2007-05-03 19:05 ` Adrian Bunk
2007-05-03 19:24 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070503175125.GL3531@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox