From: Daniel Walker <dwalker@mvista.com>
To: mingo@elte.hu
Cc: srostedt@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH -rt] wrong usage of smp_processor_id()
Date: Thu, 03 May 2007 13:08:22 -0700 [thread overview]
Message-ID: <20070503200822.696754319@mvista.com> (raw)
Found this while debugging with Steve .. trace_hardirqs_on() isn't always
called with interrupt off.
BUG: using smp_processor_id() in preemptible [00000000] code: init/1
caller is trace_hardirqs_on+0x16/0xe0
[<c01054b1>] show_trace_log_lvl+0x21/0x50
[<c0105c82>] show_trace+0x12/0x20
[<c0105d56>] dump_stack+0x16/0x20
[<c022c819>] debug_smp_processor_id+0xa9/0xb0
[<c0152a76>] trace_hardirqs_on+0x16/0xe0
[<c0103975>] do_notify_resume+0x115/0x7b0
[<c01044f4>] work_notifysig+0x13/0x1b
=======================
---------------------------
| preempt count: 00000001 ]
| 1-level deep critical section nesting:
----------------------------------------
.. [<c022c7c3>] .... debug_smp_processor_id+0x53/0xb0
.....[<c0152a76>] .. ( <= trace_hardirqs_on+0x16/0xe0)
Signed-Off-By: Daniel Walker <dwalker@mvista.com>
---
kernel/latency_trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.21/kernel/latency_trace.c
===================================================================
--- linux-2.6.21.orig/kernel/latency_trace.c
+++ linux-2.6.21/kernel/latency_trace.c
@@ -105,7 +105,7 @@ static inline int DEBUG_WARN_ON(int cond
#ifdef CONFIG_CRITICAL_IRQSOFF_TIMING
# ifdef CONFIG_CRITICAL_PREEMPT_TIMING
static DEFINE_PER_CPU(int, trace_cpu_idle);
-# define irqs_off_preempt_count() (!__get_cpu_var(trace_cpu_idle) && preempt_count())
+# define irqs_off_preempt_count() (preempt_count() && !__get_cpu_var(trace_cpu_idle))
# else
# define irqs_off_preempt_count() 0
# endif
--
--
next reply other threads:[~2007-05-03 20:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 20:08 Daniel Walker [this message]
2007-05-03 20:12 ` [PATCH -rt] wrong usage of smp_processor_id() Steven Rostedt
2007-05-03 20:21 ` Daniel Walker
2007-05-03 20:31 ` Steven Rostedt
2007-05-03 20:33 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070503200822.696754319@mvista.com \
--to=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox