Re: [PATCH 2.6.21 3/3] x86_64: EFI64 support

Eric W. Biederman
2007-06-01T18:53:18Z

Chandramouli Narayanan <mouli@linux.intel.com> writes:

> +
> +static int __init efifb_init(void)
> +{
> + int ret;
> +
> + if (!efi_enabled)
> + return -ENODEV;
> +

Please remove this efi_enabled check it appears redundant with
the check immediately below.

> + if (screen_info.orig_video_isVGA != VIDEO_TYPE_EFI)
> + return -ENODEV;
> +
> +
> + ret = platform_driver_register(&efifb_driver);
> +
> + if (!ret) {
> + ret = platform_device_register(&efifb_device);
> + if (ret)
> + platform_driver_unregister(&efifb_driver);
> + }
> + return ret;
> +}
> +module_init(efifb_init);

Eric