Re: [PATCH 2.6.21 2/3] x86_64: EFI64 support

chandramouli narayanan
2007-05-02T22:43:37Z

Andi Kleen wrote:
>> if (type && ei->type != type)
>> @@ -148,6 +178,29 @@ int __init e820_all_mapped(unsigned long
>> unsigned long __init find_e820_area(unsigned long start, unsigned long end, unsigned size)
>> {
>> int i;
>> + if (efi_enabled) {
>> + efi_memory_desc_t *md;
>>
>
> Please convert the memory map from EFI into the e820 map in one place. This
> would avoid all these weird special cases. Also custom memory map would
> just work then.
>
I will work on this and provide an update patch.
> I know i386 doesn't do it this way, but it's wrong and we'll eventually
> fix it there too.
>
> Also you have a few arbitary and white space changes in there that should be removed.
>
>
oops! I will fix this too.
> -Andi
>
- mouli