Re: [PATCH] Blacklist Dell Optiplex 320 from using the HPET

Andreas Mohr
2007-05-07T18:59:09Z

Hi,

On Sat, May 05, 2007 at 12:58:15PM -0300, Henrique de Moraes Holschuh wrote:
> On Sat, 05 May 2007, Thomas Gleixner wrote:
> > + printk(KERN_WARNING "HPET counter is defect\n");
>
> What about
> printk(KERN_WARNING "HPET counter is stopped\n");
>
> which is far more descriptive?

Far more misguiding, rather?

People may mistake this (when not realizing the KERN_WARNING output)
as a status message indicating that we actively stopped the counter.
Maybe something like
"HPET counter inoperable or defective (no increment found during probing)"?
(with an optional "please report" part)

Andreas Mohr