Re: [-mm patch] fix fs/nfs/nfsroot.c compile error

Trond Myklebust
2007-05-07T13:12:42Z

On Mon, 2007-05-07 at 12:56 +0200, Adrian Bunk wrote:
> On Mon, May 07, 2007 at 11:47:51AM +0100, David Howells wrote:
> > Adrian Bunk <bunk@stusta.de> wrote:
> >
> > > match_table_t was made "const" and gcc doesn't like "const __initdata":
> >
> > Hmmm... My gcc seems quite happy with it. What gcc are you using?
>
> 4.1
>
> > Shouldn't __initdata override const?
> >
> > > BTW: Why is this change to include/linux/parser.h in the net tree?
> >
> > Because DaveM picked it up as part of my AFS patches, I guess.
>
> It might make sense, but it doesn't seem to be in any way AFS specific.

It makes little or no sense to be forcing attributes like 'const' in a
typedef. That is basically stating that it is inconceivable to use
anything else. Clearly not the case here...

Trond