From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933669AbXEFMz6 (ORCPT ); Sun, 6 May 2007 08:55:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933663AbXEFMz6 (ORCPT ); Sun, 6 May 2007 08:55:58 -0400 Received: from smtp4.pp.htv.fi ([213.243.153.38]:33773 "EHLO smtp4.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933662AbXEFMz5 (ORCPT ); Sun, 6 May 2007 08:55:57 -0400 Date: Sun, 6 May 2007 15:55:55 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Geert Uytterhoeven Cc: Linus Torvalds , Andrew Morton , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch 06/33] m68k: CROSS_COMPILE = m68k-linux-gnu- Message-ID: <20070506125555.GA9866@sci.fi> References: <20070501203234.252205858@mail.of.borg> <20070501203330.778353898@mail.of.borg> <20070501225605.GA5533@sci.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 06, 2007 at 01:26:17PM +0200, Geert Uytterhoeven wrote: > On Wed, 2 May 2007, Ville Syrj?l? wrote: > > On Tue, May 01, 2007 at 10:32:40PM +0200, Geert Uytterhoeven wrote: > > > Recent cross-compilers are called m68k-linux-gnu-gcc instead of m68k-linux-gcc > > > > > > Signed-off-by: Geert Uytterhoeven > > > --- > > > arch/m68k/Makefile | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > --- linux-m68k-2.6.21.orig/arch/m68k/Makefile > > > +++ linux-m68k-2.6.21/arch/m68k/Makefile > > > @@ -21,7 +21,7 @@ AS += -m68020 > > > LDFLAGS := -m m68kelf > > > ifneq ($(COMPILE_ARCH),$(ARCH)) > > > # prefix for cross-compiling binaries > > > - CROSS_COMPILE = m68k-linux- > > > + CROSS_COMPILE = m68k-linux-gnu- > > > endif > > > > > > ifdef CONFIG_SUN3 > > > > What about using ?= so the user can override it. I sent a patch doing > > just that but never got any response. > > I just gave it a try, and compilation failed because it used plain gcc > instead of m68k-linux-gnu-gcc. Argh. You're correct of course. Apparently I never tried it without setting CROSS_COMPILE. The problem is in the top level Makefile: CROSS_COMPILE ?= and export CROSS_COMPILE If I remove those it works, but I don't know if removing them is a good idea in general (especially the export). Maybe the ?= thing can be removed and the export can be moved after including the arch Makefile? -- Ville Syrjälä syrjala@sci.fi http://www.sci.fi/~syrjala/