Re: [patch 01/10] compiler: define __attribute_unused__

Robert P. J. Day
2007-05-02T07:03:05Z

On Wed, 2 May 2007, Alexey Dobriyan wrote:

> On Tue, May 01, 2007 at 09:28:18PM -0700, David Rientjes wrote:
> > +#define __attribute_unused__ __attribute__((unused))
>
> Suggest __unused which is shorter and looks compiler-neutral.

not only that, but there are numerous files that *already* use
"__unused":

$ grep -rw __unused *
... snip lots of output here ...

as well as a few files that can now have their definition of that
removed:

$ grep -r "define __unused" *
drivers/net/defxx.c:#define __unused __attribute__ ((unused))
drivers/net/declance.c:#define __unused __attribute__ ((unused))
drivers/misc/thinkpad_acpi.c:#define __unused __attribute__ ((unused))

i think "__unused" is the clear choice here.

rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================