Re: [patch 01/10] compiler: define __attribute_unused__

Adrian Bunk
2007-05-03T17:51:30Z

On Wed, May 02, 2007 at 10:16:15AM -0700, David Rientjes wrote:
> On Wed, 2 May 2007, Adrian Bunk wrote:
>
> > If we don't want any warnings with CONFIG_PCI=n, CONFIG_SYSFS=n or
> > CONFIG_PROC_FS=n, we'd have to annotate _many_ functions.
> >
> > If the lonterm goal is to compile the kernel with -Werror then we need
> > -Wno-unused-function, not annotating individual functions.
>
> That's only addressing part of the issue. What about automatic or static
> external variables that are declared but may go unreferenced depending on

This is only about static code. For non-static code it would be
impossible for gcc to issue warnings.

> preprocessor macros? You need to annotate them with __attribute__
> ((unused)) to suppress compiler warnings. Globally disabling such
> warnings would eventually cause unused code to go unnoticed.

But looking at a kernel build it seems there are far few warnings than I
remembered, so it might actually be possible to annotate all code
accordingly.

> David

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed