Re: [patch 01/10] compiler: define __attribute_unused__

Adrian Bunk
2007-05-02T15:05:48Z

On Wed, May 02, 2007 at 04:55:50PM +0200, Adrian Bunk wrote:
>
> "many ... are marked __attribute__ ((unused))" is not true:
> $ grep -r __attribute_used__ * | wc -l
> 60
> $

Sorry, my fault - I confused used and unused.

>...
> Unused static non-inline functions are the only functions resulting in
> warnings when being unused.
> If we don't want gcc to emit warnings for such, we could disable them
> globally.

But this point still stands:

If we don't want any warnings with CONFIG_PCI=n, CONFIG_SYSFS=n or
CONFIG_PROC_FS=n, we'd have to annotate _many_ functions.

If the lonterm goal is to compile the kernel with -Werror then we need
-Wno-unused-function, not annotating individual functions.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed