From: Pavel Machek <pavel@ucw.cz>
To: Anton Vorontsov <cbou@mail.ru>
Cc: Greg KH <gregkh@suse.de>,
linux-kernel@vger.kernel.org, kernel-discuss@handhelds.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 5/8] APM emulation driver for class batteries
Date: Mon, 7 May 2007 14:01:48 +0000 [thread overview]
Message-ID: <20070507140148.GC3868@ucw.cz> (raw)
In-Reply-To: <20070503213237.GE20067@zarina>
Hi!
> Signed-off-by: Anton Vorontsov <cbou@mail.ru>
> ---
> drivers/power/Kconfig | 7 ++
> drivers/power/Makefile | 1 +
> drivers/power/apm_power.c | 249 +++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 257 insertions(+), 0 deletions(-)
> create mode 100644 drivers/power/apm_power.c
>
> +#ifdef current
> +#undef current /* it expands to get_current() */
> +#endif
Uff, now that's a dirty hack. Can you rename your variables? current
-> I?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-05-07 14:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 21:32 [PATCH 5/8] APM emulation driver for class batteries Anton Vorontsov
2007-05-07 14:01 ` Pavel Machek [this message]
2007-05-07 14:16 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070507140148.GC3868@ucw.cz \
--to=pavel@ucw.cz \
--cc=cbou@mail.ru \
--cc=dwmw2@infradead.org \
--cc=gregkh@suse.de \
--cc=kernel-discuss@handhelds.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox