public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Venki Pallipadi <venkatesh.pallipadi@intel.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>,
	Thomas Gleixner <tglx@linutronix.de>, Andi Kleen <ak@suse.de>,
	Ingo Molnar <mingo@elte.hu>, Chris Wright <chrisw@sous-sol.org>
Subject: [PATCH 3/8] kernel irqbalance fixes to handle IRQs with balancing disabled
Date: Mon, 7 May 2007 13:30:16 -0700	[thread overview]
Message-ID: <20070507203015.GC3926@linux-os.sc.intel.com> (raw)



kernel irq balance code moves IRQs around without checking whether
they are movable or not. Add those checks.

Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>

Index: linux-2.6.21-tolkml/arch/i386/kernel/io_apic.c
===================================================================
--- linux-2.6.21-tolkml.orig/arch/i386/kernel/io_apic.c	2007-04-25 20:08:32.000000000 -0700
+++ linux-2.6.21-tolkml/arch/i386/kernel/io_apic.c	2007-05-07 09:54:50.000000000 -0700
@@ -446,7 +446,7 @@
 	Dprintk("Rotating IRQs among CPUs.\n");
 	for_each_online_cpu(i) {
 		for (j = 0; j < NR_IRQS; j++) {
-			if (!irq_desc[j].action)
+			if (!irq_desc[j].action || irq_balancing_disabled(j))
 				continue;
 			/* Is it a significant load ?  */
 			if (IRQ_DELTA(CPU_TO_PACKAGEINDEX(i),j) <
@@ -582,7 +582,7 @@
 	selected_irq = -1;
 	for (j = 0; j < NR_IRQS; j++) {
 		/* Is this an active IRQ? */
-		if (!irq_desc[j].action)
+		if (!irq_desc[j].action || irq_balancing_disabled(j))
 			continue;
 		if (imbalance <= IRQ_DELTA(max_loaded,j))
 			continue;
@@ -665,6 +665,9 @@
 	
 	/* push everything to CPU 0 to give us a starting point.  */
 	for (i = 0 ; i < NR_IRQS ; i++) {
+		if (irq_balancing_disabled(i))
+			continue;
+
 		irq_desc[i].pending_mask = cpumask_of_cpu(0);
 		set_pending_irq(i, cpumask_of_cpu(0));
 	}

                 reply	other threads:[~2007-05-07 20:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070507203015.GC3926@linux-os.sc.intel.com \
    --to=venkatesh.pallipadi@intel.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=chrisw@sous-sol.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox