From: Pavel Machek <pavel@ucw.cz>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Anton Vorontsov <cbou@mail.ru>, Greg KH <gregkh@suse.de>,
linux-kernel@vger.kernel.org, kernel-discuss@handhelds.org,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 8/8] One Laptop Per Child power/battery driver
Date: Mon, 7 May 2007 22:38:12 +0200 [thread overview]
Message-ID: <20070507203812.GA18400@elf.ucw.cz> (raw)
In-Reply-To: <1178567497.11851.229.camel@pmac.infradead.org>
On Mon 2007-05-07 20:51:37, David Woodhouse wrote:
> On Mon, 2007-05-07 at 19:49 +0000, Pavel Machek wrote:
> > We had this discussion before. Kernel sources should be us-ascii.
> > utf-8 is ok for documentation.
>
> /* This _is_ documentation. Go away. */
No, that's a comment. Fix your code.
(And besides, comments are supposed to be useful. Patch contained
something like...
int voltage; /* ??V */
...which is pretty unhelpful. We still stick to 80 columns in the
code, and bigger displays certainly predate utf-8 compatibility. Plus,
you'd have to convert large part of Czech republic before I could
reasonably use utf-8).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-05-07 20:38 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 21:33 [PATCH 8/8] One Laptop Per Child power/battery driver Anton Vorontsov
2007-05-07 14:04 ` Pavel Machek
2007-05-07 14:12 ` Anton Vorontsov
2007-05-07 15:10 ` David Woodhouse
2007-05-07 19:49 ` Pavel Machek
2007-05-07 19:51 ` David Woodhouse
2007-05-07 20:38 ` Pavel Machek [this message]
2007-05-07 21:43 ` Alan Cox
2007-05-08 5:39 ` Willy Tarreau
2007-05-07 20:04 ` Satyam Sharma
2007-05-08 17:45 ` Maciej W. Rozycki
2007-05-08 17:52 ` Stephen Clark
2007-05-08 17:52 ` David Woodhouse
2007-05-09 14:23 ` Maciej W. Rozycki
2007-05-09 14:46 ` David Woodhouse
2007-05-09 20:33 ` Pavel Machek
2007-05-11 12:43 ` David Woodhouse
2007-05-11 13:21 ` Pavel Machek
2007-05-12 21:11 ` Adrian Bunk
2007-05-12 23:20 ` Pavel Machek
2007-05-13 4:45 ` David Woodhouse
2007-05-13 16:40 ` Krzysztof Halasa
2007-05-11 13:21 ` Alan Cox
2007-05-11 13:45 ` Satyam Sharma
2007-05-12 16:35 ` Pete Zaitcev
2007-05-13 5:39 ` David Woodhouse
2007-05-13 6:03 ` Pete Zaitcev
2007-05-13 6:21 ` David Woodhouse
2007-05-07 21:23 ` Alan Cox
2007-05-07 21:55 ` Dmitry Torokhov
2007-05-07 22:02 ` Alan Cox
2007-05-08 12:18 ` Stephen Clark
2007-05-12 17:03 ` Pete Zaitcev
2007-05-12 19:27 ` Alan Cox
2007-05-12 19:31 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070507203812.GA18400@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=cbou@mail.ru \
--cc=dwmw2@infradead.org \
--cc=gregkh@suse.de \
--cc=kernel-discuss@handhelds.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox