public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrey Borzenkov <arvidjaar@mail.ru>
To: hirofumi@mail.parknet.co.jp
Cc: linux-kernel@vger.kernel.org
Subject: Long file names in VFAT broken with iocharset=utf8
Date: Mon, 7 May 2007 21:51:14 +0400	[thread overview]
Message-ID: <200705072151.20104.arvidjaar@mail.ru> (raw)

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

This was posted in one of Russian forums. It was not possible to archive 
(under Linux, using tar) vfat directory where files had long Russian names 
(really long - over 150 - 170 characters) - tar returned stat failure. When 
looking with plain ls, file names appeared truncated.

Now looking at current (2.6.21) fat driver, __fat_readdir allocates large 
enough buffer (PAGE_SIZE-522) for UTF-8 name; but for iocharset=utf8 it calls 
uni16_to_x8() which artificially limits length of UTF-8 name to 256 ... which 
is obviously not enough for long UTF-8 Russian string (2 bytes per character) 
not to mention the - theoretical - general case of 6 bytes UTF-8 characters.

Similar problem has apparently vfat_lookup()->...->fat_search_long() call 
chain. Except this appears to be broken even in case of "utf8", because 
fat_search_long allocates fixed 256 bytes buffer for UTF-8 name.

Am I off track here?

-andrey

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

             reply	other threads:[~2007-05-07 17:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-07 17:51 Andrey Borzenkov [this message]
2007-05-07 18:07 ` Long file names in VFAT broken with iocharset=utf8 Roland Kuhn
2007-05-07 18:17   ` Andreas Schwab
2007-05-07 18:43     ` Andrey Borzenkov
2007-05-07 18:52       ` OGAWA Hirofumi
2007-05-07 18:27   ` OGAWA Hirofumi
2007-05-07 19:34     ` H. Peter Anvin
2007-05-07 19:59     ` Roland Kuhn
2007-05-07 21:01       ` OGAWA Hirofumi
2007-05-07 21:12       ` H. Peter Anvin
2007-05-09 10:27       ` Andrey Borzenkov
  -- strict thread matches above, loose matches on Subject: below --
2007-05-08  4:43 Albert Cahalan
2007-05-08  8:38 ` Jan Engelhardt
2007-05-09 15:34   ` Albert Cahalan
2007-05-09 15:57     ` Andrey Borzenkov
2007-05-09 23:49       ` Albert Cahalan
     [not found] <8ipOe-5KI-3@gated-at.bofh.it>
2007-05-08 16:21 ` Bodo Eggert
     [not found] ` <8ityz-2Xz-31@gated-at.bofh.it>
     [not found]   ` <8iWqS-5Ba-15@gated-at.bofh.it>
     [not found]     ` <8iWKp-619-29@gated-at.bofh.it>
     [not found]       ` <8j4eK-QR-13@gated-at.bofh.it>
2007-05-10 14:49         ` Bodo Eggert
2007-05-10 14:59           ` Jan Engelhardt
2007-05-10 16:14             ` John Anthony Kazos Jr.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705072151.20104.arvidjaar@mail.ru \
    --to=arvidjaar@mail.ru \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox