Re: [spi-devel-general] adding bits_per_word to struct spi_board_info to mirror struct spi_device

David Brownell
2007-05-08T05:00:42Z

On Monday 07 May 2007, Bryan WU wrote:

> currently, there are some duplicated data members in spi_device struct
> spi_board_info struct. This two structs are confused driver writers and
> boards driver users.

How would that confusion arise? Only arch/.../board-xxx.c writers
normally even see spi_board_info; the exception is that someone who
writes an add-on board -- maybe a USB-to-SPI adapter -- would call the
rarely used spi_new_device() routine.

Developers writing a SPI drivers -- controller drivers touching some
SOC's serial controller hardware, or "struct spi_driver" protocol code
talking to a chip through such a controller -- never see board info.
They only see "struct spi_device". So I don't see why they would have
a reason to be confused.

- Dave