From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
Prarit Bhargava <prarit@redhat.com>,
Andi Kleen <andi@basil.nowhere.org>
Subject: Please revert 86c0baf123e474b6eb404798926ecf62b426bf3a
Date: Tue, 8 May 2007 14:49:28 +0100 [thread overview]
Message-ID: <20070508134928.GA13212@flint.arm.linux.org.uk> (raw)
The change:
+#ifdef CONFIG_HOTPLUG_CPU
+#define __INIT .section ".text","ax"
+#define __INITDATA .section ".data","aw"
+#else
#define __INIT .section ".init.text","ax"
-#define __FINIT .previous
#define __INITDATA .section ".init.data","aw"
+#endif
+#define __FINIT .previous
breaks ARM, since the ARM startup code moves from the start of the image
to somewhere in the middle of the kernel image. (That's trivially fixable.)
Besides that, this change is also wrong because not all assembly marked
__INIT needs to be moved into the standard .text segment when hotplug CPU
is enabled. Ditto for __INITDATA.
One is left wondering why the original patch proposers didn't:
1. Invent __CPUINIT and __CPUINITDATA, to be consistent with __init vs
__cpuinit.
2. copy other architecture maintainers.
Shall I invent __CPUINIT to mark data to always be thrown away, or are
the x86 folk going to withdraw this patch and do it properly?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next reply other threads:[~2007-05-08 13:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 13:49 Russell King [this message]
2007-05-08 14:07 ` Please revert 86c0baf123e474b6eb404798926ecf62b426bf3a Prarit Bhargava
2007-05-08 15:17 ` Linus Torvalds
2007-05-08 15:19 ` Prarit Bhargava
2007-05-08 15:54 ` Russell King
2007-05-08 15:56 ` Prarit Bhargava
2007-05-13 10:56 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070508134928.GA13212@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=andi@basil.nowhere.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox