Re: New Mitsumi legacy CD-ROM driver

Pekka Enberg
2007-05-08T13:53:45Z

Hi Rene,

On 5/8/07, Rene Herman <rene.herman@gmail.com> wrote:
> +static int __mitsumi_read_toc(struct mitsumi_cdrom *mcd)
> +{
> + int tracks = mcd->header.cdth_trk1 - mcd->header.cdth_trk0 + 1;
> + int retries;
> + int err = 0;
> +
> + kfree(mcd->toc);
> +
> + mcd->toc = kzalloc(tracks * sizeof *mcd->toc, GFP_KERNEL);

Perhaps we should use krealloc() + memset() here?