Re: [PATCH] Make bootsector stub 16-bit-only (i386)

H. Peter Anvin
2007-05-08T22:27:48Z

Alexander van Heukelum wrote:
> On Tue, May 08, 2007 at 11:45:47AM -0700, H. Peter Anvin wrote:
>> Alexander van Heukelum wrote:
>>> Oh! A padding hole in a struct! That could be a problem. If the freeze
>>> is after decompression, could you test if this makes it work again?
>>>
>> The correct fix is to apply __attribute__((packed)) to this structure.
>
> Yeah, I thought about that possibility too, but the struct didn't need
> that (in my opinion ugly) annotation before. Oh well, here you go.
>

It did need it, however, it just "happened to work" anyway.

Yes, it's ugly, but the damage is already done.

-hpa