Re: [PATCH] Make bootsector stub 16-bit-only (i386)

H. Peter Anvin
2007-05-08T18:46:06Z

Alexander van Heukelum wrote:
>
> Oh! A padding hole in a struct! That could be a problem. If the freeze
> is after decompression, could you test if this makes it work again?
>

The correct fix is to apply __attribute__((packed)) to this structure.
Of course, changing the boot sector will cause different random values
to be poked into this field...

I actually caught this during my setup code rewrite, but I forgot that
in the old setup code the parameter structure overlays the boot sector
(it doesn't in my code -- it starts out with nice clean zero-filled memory.)

-hpa