From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969982AbXEHXcj (ORCPT ); Tue, 8 May 2007 19:32:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S969758AbXEHXbp (ORCPT ); Tue, 8 May 2007 19:31:45 -0400 Received: from ozlabs.org ([203.10.76.45]:48788 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967846AbXEHXbn (ORCPT ); Tue, 8 May 2007 19:31:43 -0400 Date: Wed, 9 May 2007 09:30:26 +1000 From: David Gibson To: Loeliger Jon-LOELIGER Cc: Vitaly Bordug , linuxppc-dev@ozlabs.org, linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] [POWERPC] dts: kill hardcoded phandles Message-ID: <20070508233026.GA2112@localhost.localdomain> Mail-Followup-To: Loeliger Jon-LOELIGER , Vitaly Bordug , linuxppc-dev@ozlabs.org, linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org References: <20070508055431.GA21009@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 08, 2007 at 07:29:20AM -0700, Jon Loeliger wrote: > > > > - interrupt-controller@f8200000 { > > > - linux,phandle = ; > > > + pci_pic:interrupt-controller@f8200000 { > > > > I'd like to establish a convention of putting a space after the : and > > using capitals for labels unless there's a strong reason not to in a > > particular case. It makes them easier to visually distinguish next to > > the node name. > > Colon-space is easy and I'll buy it. > I'm not big on uppercase shouting, though. I don't think it will really be any more shouty than the convention of using caps for simple constant #defines. The Ebony device tree uses this now, and I think it turns out quite well (though in that case there's the additional reason to use caps that the labels are based on the component names used in the 440GP user manual, which are given as caps). -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson