From: Jarek Poplawski <jarkao2@o2.pl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Venki Pallipadi <venkatesh.pallipadi@intel.com>,
linux-kernel@vger.kernel.org, Oleg Nesterov <oleg@tv-sign.ru>
Subject: Re: [PATCH -mm] timer: parenthesis fix in tbase_get_deferrable() etc.
Date: Wed, 9 May 2007 07:31:44 +0200 [thread overview]
Message-ID: <20070509053144.GA995@ff.dom.local> (raw)
In-Reply-To: <20070508163358.9cc482a8.akpm@linux-foundation.org>
On Tue, May 08, 2007 at 04:33:58PM -0700, Andrew Morton wrote:
> On Tue, 8 May 2007 12:33:48 +0200
> Jarek Poplawski <jarkao2@o2.pl> wrote:
>
> >
> > Signed-off-by: Jarek Poplawski <jarkao2@o2.pl>
> >
> > ---
> >
> > diff -Nurp 2.6.21-mm1-/kernel/timer.c 2.6.21-mm1/kernel/timer.c
> > --- 2.6.21-mm1-/kernel/timer.c 2007-05-08 11:54:48.000000000 +0200
> > +++ 2.6.21-mm1/kernel/timer.c 2007-05-08 12:05:11.000000000 +0200
> > @@ -92,24 +92,24 @@ static DEFINE_PER_CPU(tvec_base_t *, tve
> > /* Functions below help us manage 'deferrable' flag */
> > static inline unsigned int tbase_get_deferrable(tvec_base_t *base)
> > {
> > - return ((unsigned int)(unsigned long)base & TBASE_DEFERRABLE_FLAG);
> > + return (unsigned int)((unsigned long)base & TBASE_DEFERRABLE_FLAG);
> > }
...
> The change makes sense, but does it actually "fix" anything?
>
Yes - this first place fixes logical error, so it's a sin
- even if not punishable in practice. (It's also unnecessary
test for long to int conversion.)
Other changes are only BTW.
Regards,
Jarek P.
next prev parent reply other threads:[~2007-05-09 5:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 10:33 [PATCH -mm] timer: parenthesis fix in tbase_get_deferrable() etc Jarek Poplawski
2007-05-08 23:33 ` Andrew Morton
2007-05-09 5:31 ` Jarek Poplawski [this message]
2007-05-09 15:59 ` Pallipadi, Venkatesh
2007-05-09 18:29 ` Satyam Sharma
2007-05-09 19:10 ` Pallipadi, Venkatesh
2007-05-10 7:39 ` Jarek Poplawski
2007-05-10 7:57 ` Andrew Morton
2007-05-10 9:29 ` [PATCH] timer: revert " Jarek Poplawski
2007-05-10 9:35 ` Jarek Poplawski
2007-05-10 8:26 ` [PATCH -mm] timer: " Satyam Sharma
2007-05-10 9:32 ` Satyam Sharma
2007-05-10 5:52 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070509053144.GA995@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox