From: Andrew Morton <akpm@linux-foundation.org>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: suresh.b.siddha@intel.com, linux-kernel@vger.kernel.org,
clameter@sgi.com
Subject: Re: [PATCH 2/2] Call percpu smp cacheline algin interface
Date: Wed, 9 May 2007 13:33:28 -0700 [thread overview]
Message-ID: <20070509133328.c79ef48e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070507225944.GA15372@linux-os.sc.intel.com>
On Mon, 7 May 2007 15:59:44 -0700
Fenghua Yu <fenghua.yu@intel.com> wrote:
> On Fri, May 04, 2007 at 05:12:31PM -0700, Fenghua Yu wrote:
> >
> > Call percpu smp cacheline align interface.
> >
>
> This is updated patch. Use new macro name DEFINE_PER_CPU_SHARED_CACHELINE_ALIGNED for better code understanding.
>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
hm, DEFINE_PER_CPU_SHARED_CACHELINE_ALIGNED is a bit of a mouthful.
I wonder if we can improve things here so that we use the runtime-detected
cacheline size rather than the compile-time size. I guess not, given that
the offsets into the percpu area are calculated at build-time.
Did you work out how much space this change will actually save? It
should be available by suitable crunching on the nm and objdump output.
next prev parent reply other threads:[~2007-05-09 20:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <33E1C72C74DBE747B7B59C1740F7443701A2F0AB@orsmsx417.amr.corp.intel.com>
2007-05-05 0:12 ` [PATCH 1/2] Define percpu smp cacheline align interface Fenghua Yu
2007-05-07 22:58 ` Fenghua Yu
2007-05-15 23:42 ` Andrew Morton
2007-05-05 0:12 ` [PATCH 0/2] Add percpu smp cacheline align section Fenghua Yu
2007-05-05 16:52 ` Christoph Lameter
2007-05-07 17:11 ` Siddha, Suresh B
2007-05-07 17:30 ` Christoph Lameter
2007-05-07 17:46 ` Siddha, Suresh B
2007-05-07 18:13 ` Yu, Fenghua
2007-05-15 0:12 ` [PATCH 2/2] Use the new percpu interface for shared data -- version 2 Fenghua Yu
[not found] ` <20070515001255.GA27978@linux-os.sc.intel.com>
2007-05-15 0:22 ` [PATCH 1/2] Define " Fenghua Yu
2007-05-05 0:12 ` [PATCH 2/2] Call percpu smp cacheline algin interface Fenghua Yu
2007-05-07 22:59 ` Fenghua Yu
2007-05-09 20:33 ` Andrew Morton [this message]
2007-05-09 22:16 ` Yu, Fenghua
2007-05-09 22:53 ` Andrew Morton
2007-05-09 22:56 ` Christoph Lameter
2007-05-09 23:06 ` Siddha, Suresh B
2007-05-09 23:10 ` Yu, Fenghua
2007-05-09 23:36 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070509133328.c79ef48e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox