From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758203AbXEIPzg (ORCPT ); Wed, 9 May 2007 11:55:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754218AbXEIPza (ORCPT ); Wed, 9 May 2007 11:55:30 -0400 Received: from mx1.redhat.com ([66.187.233.31]:60141 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754139AbXEIPz3 (ORCPT ); Wed, 9 May 2007 11:55:29 -0400 Date: Wed, 9 May 2007 16:54:11 +0100 From: Alasdair G Kergon To: Jens Axboe Cc: Andrew Morton , dm-devel@redhat.com, linux-kernel@vger.kernel.org, Heinz Mauelshagen Subject: Re: [2.6.22 PATCH 22/26] dm: bio list helpers Message-ID: <20070509155411.GD18152@agk.fab.redhat.com> Mail-Followup-To: Jens Axboe , Andrew Morton , dm-devel@redhat.com, linux-kernel@vger.kernel.org, Heinz Mauelshagen References: <20070508194845.GC24114@agk.fab.redhat.com> <20070508174159.7d78a275.akpm@linux-foundation.org> <20070509064923.GO4163@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070509064923.GO4163@kernel.dk> User-Agent: Mutt/1.4.1i Organization: Red Hat UK Ltd. Registered in England and Wales, number 03798903. Registered Office: Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE. Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 09, 2007 at 08:49:23AM +0200, Jens Axboe wrote: > Besides, manual prefetching is very rarely a win. I dabbled with some > benchmarks a few weeks back (with the doubly linked lists), and in most > cases it was actually a loss. So I'd vote for just removing the > prefetch() above. OK. Alasdair -- agk@redhat.com