public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Richard Purdie <richard@openedhand.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	torvalds@linux-foundation.org,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] Add LZO1X compression support to the kernel
Date: Wed, 9 May 2007 23:21:29 -0700	[thread overview]
Message-ID: <20070509232129.371f49d5.akpm@linux-foundation.org> (raw)
In-Reply-To: <1178096183.5860.25.camel@localhost.localdomain>

On Wed, 02 May 2007 09:56:23 +0100 Richard Purdie <richard@openedhand.com> wrote:

> Current thinking is that lzo should get merged directly followed by the
> subsystem parts through their specific trees. It appears this should
> make it onto LKML despite the size so here goes.
> 
> Please keep in mind I haven't reformatted the LZO code itself as if I do
> so, it will make maintenance of it against any changes in LZO itself
> near impossible. In its current form, it should be possible to diff
> against upstream. All the bad formatting is confined to a handful of
> files in lib/lzo/ and the kernel interface should be clean.
> 
> I realise a maze of ifdefs still remain. I've already spent a lot of
> time removing a ton of them and going much further might start to affect
> diffability of the code - I hoping whats there is a good compromise.
> 
> I've asked the LZO author about the comments on lzo_copyright function
> but the code is GPLv2 licensed so is suitable for inclusion in the
> kernel.
> 
> 
> 
> Add LZO1X compression/decompression support to the kernel.
> 
> This is based on the standard userspace lzo library, particularly
> minilzo with the headers much trimmed down and simplified for kernel
> use. Its structured so that it should still diff with the userspace
> version for ease of future updating.

Well that's attractive-looking code.

Why is this needed?  What code plans to use it?

How many buffer overruns are there in it?


  parent reply	other threads:[~2007-05-10  6:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-02  8:56 [PATCH] Add LZO1X compression support to the kernel Richard Purdie
2007-05-02  9:35 ` Pekka Enberg
2007-05-04 18:28   ` Satyam Sharma
2007-05-10  6:21 ` Andrew Morton [this message]
2007-05-10  8:26   ` David Woodhouse
2007-05-10  8:53     ` Richard Purdie
2007-05-10 14:30   ` Jan Engelhardt
2007-05-12 11:17 ` Adrian Bunk
2007-05-12 15:17   ` Richard Purdie
2007-05-12 16:47     ` Andrew Morton
2007-05-12 20:56       ` Richard Purdie
2007-05-13 11:59         ` Markus F.X.J. Oberhumer
  -- strict thread matches above, loose matches on Subject: below --
2007-05-10  8:49 Tomasz Chmielewski
2007-05-11 20:48 devzero
2007-05-13 13:06 ` Jindrich Makovicka
2007-05-12 10:41 devzero
2007-05-12 11:41 ` Jindrich Makovicka
2007-05-12 19:51   ` Satyam Sharma
2007-05-15 16:54 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070509232129.371f49d5.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard@openedhand.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox