Re: remove broken URLs from net drivers' output

Re: remove broken URLs from net drivers' output

[Jeff Garzik]

Linux Kernel Mailing List wrote:
> Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2c2a8c531e953c753b06605c8ad6a9161ca527fa
> Commit:     2c2a8c531e953c753b06605c8ad6a9161ca527fa
> Parent:     b96687768a9ac0fdd005c7700093ebb24b93450f
> Author:     Markus Dahms <dahms@fh-brandenburg.de>
> AuthorDate: Wed May 9 07:58:10 2007 +0200
> Committer:  Adrian Bunk <bunk@stusta.de>
> CommitDate: Wed May 9 08:58:18 2007 +0200
> 
>     remove broken URLs from net drivers' output
>     
>     Remove broken URLs (www.scyld.com) from network drivers' logging output.
>     URLs in comments and other strings are left intact.
>     
>     Signed-off-by: Markus Dahms <dahms@fh-brandenburg.de>
>     Acked-by: Jesper Juhl <jesper.juhl@gmail.com>
>     Acked-by: Alan Cox <alan@redhat.com>
>     igned-off-by: Adrian Bunk <bunk@stusta.de>
> ---
>  drivers/net/3c509.c     |    5 ++---
>  drivers/net/3c59x.c     |    2 +-
>  drivers/net/atp.c       |    8 +++-----
>  drivers/net/eepro100.c  |    2 +-
>  drivers/net/epic100.c   |   10 ++++------
>  drivers/net/natsemi.c   |    1 -
>  drivers/net/ne2k-pci.c  |    3 +--
>  drivers/net/sundance.c  |    3 +--
>  drivers/net/yellowfin.c |    1 -
>  9 files changed, 13 insertions(+), 22 deletions(-)

Grumble...  This stuff should go through my tree.

	Jeff

Re: remove broken URLs from net drivers' output

[Jesper Juhl]

On 10/05/07, Jeff Garzik <jeff@garzik.org> wrote:
> Linux Kernel Mailing List wrote:
> > Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2c2a8c531e953c753b06605c8ad6a9161ca527fa
> > Commit:     2c2a8c531e953c753b06605c8ad6a9161ca527fa
> > Parent:     b96687768a9ac0fdd005c7700093ebb24b93450f
> > Author:     Markus Dahms <dahms@fh-brandenburg.de>
> > AuthorDate: Wed May 9 07:58:10 2007 +0200
> > Committer:  Adrian Bunk <bunk@stusta.de>
> > CommitDate: Wed May 9 08:58:18 2007 +0200
> >
> >     remove broken URLs from net drivers' output
> >
> >     Remove broken URLs (www.scyld.com) from network drivers' logging output.
> >     URLs in comments and other strings are left intact.
> >
> >     Signed-off-by: Markus Dahms <dahms@fh-brandenburg.de>
> >     Acked-by: Jesper Juhl <jesper.juhl@gmail.com>
> >     Acked-by: Alan Cox <alan@redhat.com>
> >     igned-off-by: Adrian Bunk <bunk@stusta.de>
> > ---
> >  drivers/net/3c509.c     |    5 ++---
> >  drivers/net/3c59x.c     |    2 +-
> >  drivers/net/atp.c       |    8 +++-----
> >  drivers/net/eepro100.c  |    2 +-
> >  drivers/net/epic100.c   |   10 ++++------
> >  drivers/net/natsemi.c   |    1 -
> >  drivers/net/ne2k-pci.c  |    3 +--
> >  drivers/net/sundance.c  |    3 +--
> >  drivers/net/yellowfin.c |    1 -
> >  9 files changed, 13 insertions(+), 22 deletions(-)
>
> Grumble...  This stuff should go through my tree.
>
>         Jeff
>

Note, just for the record; I never explicitly added an Acked-by to
this patch, I only said in a conversational email that it made sense
to me...
I don't actually mind, in this case, to have an Acked-by tagged on
with my name,  but in general I think that such lines should only be
added when people explicitly say Acked-by: John Doe, or something like
"Feel free to add my ACK to this" etc.


-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

Re: remove broken URLs from net drivers' output

[Adrian Bunk]

On Wed, May 09, 2007 at 06:41:22PM -0400, Jeff Garzik wrote:
> Linux Kernel Mailing List wrote:
>> Gitweb:     
>> http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2c2a8c531e953c753b06605c8ad6a9161ca527fa
>> Commit:     2c2a8c531e953c753b06605c8ad6a9161ca527fa
>> Parent:     b96687768a9ac0fdd005c7700093ebb24b93450f
>> Author:     Markus Dahms <dahms@fh-brandenburg.de>
>> AuthorDate: Wed May 9 07:58:10 2007 +0200
>> Committer:  Adrian Bunk <bunk@stusta.de>
>> CommitDate: Wed May 9 08:58:18 2007 +0200
>>     remove broken URLs from net drivers' output
>>         Remove broken URLs (www.scyld.com) from network drivers' logging 
>> output.
>>     URLs in comments and other strings are left intact.
>>         Signed-off-by: Markus Dahms <dahms@fh-brandenburg.de>
>>     Acked-by: Jesper Juhl <jesper.juhl@gmail.com>
>>     Acked-by: Alan Cox <alan@redhat.com>
>>     igned-off-by: Adrian Bunk <bunk@stusta.de>
>> ---
>>  drivers/net/3c509.c     |    5 ++---
>>  drivers/net/3c59x.c     |    2 +-
>>  drivers/net/atp.c       |    8 +++-----
>>  drivers/net/eepro100.c  |    2 +-
>>  drivers/net/epic100.c   |   10 ++++------
>>  drivers/net/natsemi.c   |    1 -
>>  drivers/net/ne2k-pci.c  |    3 +--
>>  drivers/net/sundance.c  |    3 +--
>>  drivers/net/yellowfin.c |    1 -
>>  9 files changed, 13 insertions(+), 22 deletions(-)
>
> Grumble...  This stuff should go through my tree.

It had been sent twice to both linux-kernel and netdev, and when going 
through old linux-kernel emails I considered it trivial enough (people 
might argue about dead email addresses, but not about dead URLs).

I could send such patches to Andrew for that he includes them in -mm and 
therefore will include them in his huge list of "forward again and again 
to the maintainer until there is any reaction" patches.

But IMHO for such trivial patches it's enough if the maintainer had the 
chance to veto them.

> 	Jeff

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: remove broken URLs from net drivers' output

[Adrian Bunk]

On Thu, May 10, 2007 at 01:04:24AM +0200, Jesper Juhl wrote:
> On 10/05/07, Jeff Garzik <jeff@garzik.org> wrote:
>> Linux Kernel Mailing List wrote:
>> > Gitweb:     
>> http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2c2a8c531e953c753b06605c8ad6a9161ca527fa
>> > Commit:     2c2a8c531e953c753b06605c8ad6a9161ca527fa
>> > Parent:     b96687768a9ac0fdd005c7700093ebb24b93450f
>> > Author:     Markus Dahms <dahms@fh-brandenburg.de>
>> > AuthorDate: Wed May 9 07:58:10 2007 +0200
>> > Committer:  Adrian Bunk <bunk@stusta.de>
>> > CommitDate: Wed May 9 08:58:18 2007 +0200
>> >
>> >     remove broken URLs from net drivers' output
>> >
>> >     Remove broken URLs (www.scyld.com) from network drivers' logging 
>> output.
>> >     URLs in comments and other strings are left intact.
>> >
>> >     Signed-off-by: Markus Dahms <dahms@fh-brandenburg.de>
>> >     Acked-by: Jesper Juhl <jesper.juhl@gmail.com>
>> >     Acked-by: Alan Cox <alan@redhat.com>
>> >     igned-off-by: Adrian Bunk <bunk@stusta.de>
>> > ---
>> >  drivers/net/3c509.c     |    5 ++---
>> >  drivers/net/3c59x.c     |    2 +-
>> >  drivers/net/atp.c       |    8 +++-----
>> >  drivers/net/eepro100.c  |    2 +-
>> >  drivers/net/epic100.c   |   10 ++++------
>> >  drivers/net/natsemi.c   |    1 -
>> >  drivers/net/ne2k-pci.c  |    3 +--
>> >  drivers/net/sundance.c  |    3 +--
>> >  drivers/net/yellowfin.c |    1 -
>> >  9 files changed, 13 insertions(+), 22 deletions(-)
>>
>> Grumble...  This stuff should go through my tree.
>>
>>         Jeff
>>
>
> Note, just for the record; I never explicitly added an Acked-by to
> this patch, I only said in a conversational email that it made sense
> to me...
> I don't actually mind, in this case, to have an Acked-by tagged on
> with my name,  but in general I think that such lines should only be
> added when people explicitly say Acked-by: John Doe, or something like
> "Feel free to add my ACK to this" etc.

Did I miss that "Acked-by:" is considered to be a formal tag like 
"Signed-off-by:"?

I thought it was just an informal tag to mark which people did agree 
with the patch (and the line between your "Makes good sense to me." 
and a "Feel free to add my ACK to this" is really thin).

> Jesper Juhl

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: remove broken URLs from net drivers' output

[Jeff Garzik]

Adrian Bunk wrote:
> I thought it was just an informal tag to mark which people did agree 
> with the patch (and the line between your "Makes good sense to me." 
> and a "Feel free to add my ACK to this" is really thin).


No, the line is easy and obvious:  if there is any doubt, DO NOT ASSUME.

If they do not explicitly ACK it, then do not presume to speak for them.

	Jeff

Re: remove broken URLs from net drivers' output

[Jeff Garzik]

Adrian Bunk wrote:
> It had been sent twice to both linux-kernel and netdev, and when going 
> through old linux-kernel emails I considered it trivial enough (people 
> might argue about dead email addresses, but not about dead URLs).
> 
> I could send such patches to Andrew for that he includes them in -mm and 
> therefore will include them in his huge list of "forward again and again 
> to the maintainer until there is any reaction" patches.
> 
> But IMHO for such trivial patches it's enough if the maintainer had the 
> chance to veto them.


Please follow the rule that everybody else follows:  send to me and 
netdev.  It's that simple :)

	Jeff

Re: remove broken URLs from net drivers' output

[Adrian Bunk]

On Thu, May 10, 2007 at 12:22:59AM -0400, Jeff Garzik wrote:
> Adrian Bunk wrote:
>> I thought it was just an informal tag to mark which people did agree with 
>> the patch (and the line between your "Makes good sense to me." and a "Feel 
>> free to add my ACK to this" is really thin).
>
> No, the line is easy and obvious:  if there is any doubt, DO NOT ASSUME.
> 
> If they do not explicitly ACK it, then do not presume to speak for them.

There is no doubt that Jesper did explicitly ACK the patch.
We are ONLY discussing whether his informal ACK can be translated into 
an "Acked-by:" line.

The line I mentioned only exists if "Acked-by:" is considered a formal 
tag someone must explicitely give, and not an informal indication that 
someone agrees with the patch. But in this case, we should better 
require people to give explicit "Acked-by:" lines, like we already 
require for "Signed-off-by:" lines.

I've seen many cases where people other than me added "Acked-by:" tags 
when there was only a "Makes good sense to me." or "Fine with me.", but 
no formal "Acked-by:" given.

If "Acked-by:" should be considered a formal tag, it
- should be documented in Documentation/SubmittingPatches and
- the practice must change to always require people to give
  a formal "Acked-by:".

> 	Jeff

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: remove broken URLs from net drivers' output

[Adrian Bunk]

On Thu, May 10, 2007 at 12:23:53AM -0400, Jeff Garzik wrote:
> Adrian Bunk wrote:
>> It had been sent twice to both linux-kernel and netdev, and when going 
>> through old linux-kernel emails I considered it trivial enough (people 
>> might argue about dead email addresses, but not about dead URLs).
>> I could send such patches to Andrew for that he includes them in -mm and 
>> therefore will include them in his huge list of "forward again and again 
>> to the maintainer until there is any reaction" patches.
>> But IMHO for such trivial patches it's enough if the maintainer had the 
>> chance to veto them.
>
>
> Please follow the rule that everybody else follows:  send to me and netdev. 
>  It's that simple :)

This doesn't answer the main question:
How often, if there's no maintainer reaction?

It happens that Andrew forwards patches from me in -mm 5 or 10 times to 
a maintainer until he gets any reaction from the maintainer.

Before I'd start the same with trivial patches, it would be easier to 
change the "trivial@kernel.org" mail alias to point to Andrew so that 
trivial patches can also become part of his "forward patches to 
maintainers again and again until there's any reaction" process.

That's not meant as a threat or anything like that, it's a serious 
suggestion to avoid duplicated work.

> 	Jeff

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: remove broken URLs from net drivers' output

[Jesper Juhl]

On 10/05/07, Adrian Bunk <bunk@stusta.de> wrote:
> On Thu, May 10, 2007 at 12:22:59AM -0400, Jeff Garzik wrote:
> > Adrian Bunk wrote:
> >> I thought it was just an informal tag to mark which people did agree with
> >> the patch (and the line between your "Makes good sense to me." and a "Feel
> >> free to add my ACK to this" is really thin).
> >
> > No, the line is easy and obvious:  if there is any doubt, DO NOT ASSUME.
> >
> > If they do not explicitly ACK it, then do not presume to speak for them.
>
> There is no doubt that Jesper did explicitly ACK the patch.
> We are ONLY discussing whether his informal ACK can be translated into
> an "Acked-by:" line.
>
Right. The patch is fine. What I said when I commented on it was an
ACK, that's not being debated.
I just thought that Acked-by: was considered a lot more formal and was
surprised to see that line with my name on the patch. But I've since
checked up on that assumption and I can't find anything that states
that it is considered as formal as I thought it was, so the mistake is
all mine and what you did is fine.

If Acked-by: should be made more formal or not is a different discussion.

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html