From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Alasdair G Kergon <agk@redhat.com>,
dm-devel@redhat.com, linux-kernel@vger.kernel.org,
Heinz Mauelshagen <mauelshagen@redhat.com>
Subject: Re: [2.6.22 PATCH 23/26] dm delay:
Date: Thu, 10 May 2007 12:37:55 -0700 [thread overview]
Message-ID: <20070510123755.09dbc70c.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0705101204150.10698@schroedinger.engr.sgi.com>
On Thu, 10 May 2007 12:04:50 -0700 (PDT) Christoph Lameter <clameter@sgi.com> wrote:
> On Thu, 10 May 2007, Andrew Morton wrote:
>
> > > > + delayed_cache = kmem_cache_create("dm-delay",
> > > > + sizeof(struct delay_info),
> > > > + __alignof__(struct delay_info),
> > > > + 0, NULL, NULL);
> > >
> > > We have an ugly^Wnice new KMEM_CACHE macro for this now.
>
> How could I nicify the macro? Lower case?
Lower case would be worse, IMO. Upper-case says "this is a macro". Lower-case
macros are OK when they are macros pretending to be functions, but KMEM_CACHE
is not such a thing.
I don't think it can be nicified, except by removing it. We generally
prefer to open-code things rather than wrapping them up in macros.
But given the amount of variation amongst callers and the number of times
this got screwed up, I agree that burying those details at a single site
makes sense in this instance.
prev parent reply other threads:[~2007-05-10 19:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 19:48 [2.6.22 PATCH 23/26] dm delay: Alasdair G Kergon
2007-05-09 0:54 ` Andrew Morton
2007-05-10 19:02 ` Andrew Morton
2007-05-10 19:04 ` Christoph Lameter
2007-05-10 19:37 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070510123755.09dbc70c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=agk@redhat.com \
--cc=clameter@sgi.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mauelshagen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox