From: "J. Bruce Fields" <bfields@fieldses.org>
To: Doug Chapman <doug.chapman@hp.com>
Cc: linux-kernel@vger.kernel.org, hch@infradead.org,
Marc Eshel <eshel@almaden.ibm.com>
Subject: Re: post 2.6.21 regression in F_GETLK
Date: Thu, 10 May 2007 16:23:13 -0400 [thread overview]
Message-ID: <20070510202313.GV13719@fieldses.org> (raw)
In-Reply-To: <20070510193859.GR13719@fieldses.org>
On Thu, May 10, 2007 at 03:38:59PM -0400, bfields wrote:
> On Thu, May 10, 2007 at 03:30:50PM -0400, bfields wrote:
> > On Thu, May 10, 2007 at 02:56:15PM -0400, Doug Chapman wrote:
> > > A recent regression (introduced after 2.6.21) was caught by the LTP test
> > > fcntl11. It appears that F_GETLK is not properly checking for existing
> > > F_RDLCK and allows taking out a write lock.
Hm, actually, could you double-check the test results? Looking at your
test case, it appears that it fails when the lock returned from the
fcntl(.,F_GETLK,.) has an l_type != F_RDLCK. That doesn't necessarily
mean the F_GETLK is reporting no conflict. I believe the bug is
actually that it's reporting the wrong kind of conflict--so it's
returning l_type == F_WRLCK, not F_UNLCK.
Also, this affects only F_GETLK, not F_SETLK, so you're not actually
managing to acquire a conflicting lock, right?
--b.
next prev parent reply other threads:[~2007-05-10 20:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 18:56 post 2.6.21 regression in F_GETLK Doug Chapman
2007-05-10 19:14 ` Doug Chapman
2007-05-10 19:30 ` J. Bruce Fields
2007-05-10 19:38 ` J. Bruce Fields
2007-05-10 20:23 ` J. Bruce Fields [this message]
2007-05-10 21:01 ` Doug Chapman
2007-05-10 21:04 ` J. Bruce Fields
2007-05-10 21:35 ` J. Bruce Fields
2007-05-10 20:24 ` Doug Chapman
2007-05-10 22:38 ` [PATCH] locks: fix F_GETLK regression (failure to find conflicts) J. Bruce Fields
2007-05-10 23:30 ` Doug Chapman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070510202313.GV13719@fieldses.org \
--to=bfields@fieldses.org \
--cc=doug.chapman@hp.com \
--cc=eshel@almaden.ibm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox