linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Christoph Hellwig <hch@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Ben Fennema <bfennema@falcon.csc.calpoly.edu>,
	Jan Kara <jack@ucw.cz>
Subject: Re: [PATCH] UDF: check for allocated memory for inode data
Date: Fri, 11 May 2007 15:09:20 +0400	[thread overview]
Message-ID: <20070511110920.GA11898@cvg> (raw)
In-Reply-To: <20070511103956.GA30896@infradead.org>

[Christoph Hellwig - Fri, May 11, 2007 at 11:39:56AM +0100]
| On Fri, May 11, 2007 at 01:01:27PM +0400, Cyrill Gorcunov wrote:
| > [Christoph Hellwig - Fri, May 11, 2007 at 08:29:39AM +0100]
| > 
| > ...
| > 
| > | And please get rid of the UDF_I_* macro for everything you touch, just
| > | put a
| > | 
| > | 	struct udf_inode_info *uip = UDF_I(inode);
| > | 
| > | at the beginning of the function and use the fields directly.
| > | 
| > 
| > Actually to properly remove UDF_I* and UDF_SB_* macroses in the
| > whole UDF subsystem - is _lot_ of work. I'm going to make it but
| > not now (too busy).
| 
| Doing it completely is a lot of work, yes.  I was more thinking of
| converting a piece of code once you do major changes.  But if you
| want to convert all the code as a separate patch I'm more than happy
| aswell.
| 

Christoph, my only argue against getting rid of UDF_I_* macro in
my patch is UDF coding style, I don't want to damage it. I think
we may leave it as is (including my patch). So just review the patch
I sent (second version) and Ack it then so Andrew could include it
into mm tree. Meantime I'm rewritting the whole UDF subsystem to
get rid of that macroses (it will be a long way ;)

		Cyrill

P.S.
But if you still insist on getting rid of UDF_I_ macroses from my patch
just let me now :)


  reply	other threads:[~2007-05-11 11:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-10 14:00 [PATCH] UDF: check for allocated memory for inode data Cyrill Gorcunov
2007-05-10 22:46 ` Andrew Morton
2007-05-11  5:52   ` Cyrill Gorcunov
2007-05-11  7:29   ` Christoph Hellwig
2007-05-11  7:49     ` Cyrill Gorcunov
2007-05-11  7:57     ` Cyrill Gorcunov
2007-05-11  9:01     ` Cyrill Gorcunov
2007-05-11 10:39       ` Christoph Hellwig
2007-05-11 11:09         ` Cyrill Gorcunov [this message]
2007-05-13 21:01           ` Christoph Hellwig
2007-05-16 14:33             ` Cyrill Gorcunov
2007-05-16 17:38               ` Jan Kara
2007-05-16 17:52                 ` Cyrill Gorcunov
2007-05-16 17:56                   ` Christoph Hellwig
2007-05-20 12:20                     ` Cyrill Gorcunov
2007-05-21  8:23                       ` Jan Kara
2007-05-21 10:36                       ` Christoph Hellwig
2007-05-12 10:09         ` Cyrill Gorcunov
2007-05-12 10:15           ` Pekka Enberg
2007-05-12 11:40             ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070511110920.GA11898@cvg \
    --to=gorcunov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bfennema@falcon.csc.calpoly.edu \
    --cc=hch@infradead.org \
    --cc=jack@ucw.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).