From: Frederik Deweerdt <deweerdt@free.fr>
To: David Miller <davem@davemloft.net>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [-mm patch] make csum_and_copy_from_user arch independent
Date: Fri, 11 May 2007 15:56:18 +0200 [thread overview]
Message-ID: <20070511135618.GE23638@slug> (raw)
In-Reply-To: <20070511.021443.41636409.davem@davemloft.net>
On Fri, May 11, 2007 at 02:14:43AM -0700, David Miller wrote:
> From: Frederik Deweerdt <deweerdt@free.fr>
> Date: Fri, 11 May 2007 10:27:38 +0200
>
> > ERROR: "csum_partial_copy_from_user" [net/rxrpc/af-rxrpc.ko] undefined!
> >
> > Linking on ARM fails because albeit a generic csum_and_copy_from_user()
> > function is provided in the case ! _HAVE_ARCH_COPY_AND_CSUM_FROM_USER, the
> > generic function uses csum_partial_copy_from_user() which is i386 only.
>
> On what planet is csum_partial_copy_from_user() i386 only?
> Every single platform provides that function.
Er, my bad, I've changed my cscope bindings and I saw no results except
i386.
> The issue more-so appears to be that ARM simply fails to
> export the symbol to modules like the other platforms do.
Indeed, here's the fix.
Thanks,
Frederik
Signed-off-by: Frederik Deweerdt <frederik.deweerdt@gmail.com>
diff --git a/arch/arm/kernel/armksyms.c b/arch/arm/kernel/armksyms.c
index 4779f47..9179e82 100644
--- a/arch/arm/kernel/armksyms.c
+++ b/arch/arm/kernel/armksyms.c
@@ -76,6 +76,7 @@ EXPORT_SYMBOL(__const_udelay);
/* networking */
EXPORT_SYMBOL(csum_partial);
+EXPORT_SYMBOL(csum_partial_copy_from_user);
EXPORT_SYMBOL(csum_partial_copy_nocheck);
EXPORT_SYMBOL(__csum_ipv6_magic);
next prev parent reply other threads:[~2007-05-11 13:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-09 8:23 2.6.21-mm2 Andrew Morton
2007-05-09 14:57 ` 2.6.21-mm2 - Kconfig horkage Valdis.Kletnieks
2007-05-09 17:07 ` Christoph Lameter
2007-05-09 17:16 ` Valdis.Kletnieks
2007-05-09 18:36 ` Christoph Lameter
2007-05-09 16:08 ` 2.6.21-mm2 - 100% CPU on ksoftirqd/1 Valdis.Kletnieks
2007-05-09 17:31 ` Andrew Morton
2007-05-09 18:12 ` Jeremy Fitzhardinge
2007-05-09 20:13 ` Valdis.Kletnieks
2007-05-11 2:52 ` Valdis.Kletnieks
2007-05-09 16:51 ` 2.6.21-mm2 - hanging with initcall_debug and netconsole Valdis.Kletnieks
2007-05-09 17:37 ` Andrew Morton
2007-05-10 11:29 ` 2.6.21-mm2 -- compat_core_sys_select() kmalloc(0) Andy Whitcroft
2007-05-10 11:48 ` 2.6.21-mm2 -- powerpc missing kset Andy Whitcroft
2007-05-10 12:16 ` Stephen Rothwell
2007-05-10 15:48 ` Randy Dunlap
2007-05-10 23:45 ` Stephen Rothwell
2007-05-10 12:21 ` ixp4xx compile error (was Re: 2.6.21-mm2) Frederik Deweerdt
2007-05-10 12:45 ` Frederik Deweerdt
2007-05-10 12:56 ` Dmitry Torokhov
2007-05-10 16:11 ` 2.6.21-mm2 Marc Dietrich
2007-05-10 19:22 ` 2.6.21-mm2 Andrew Morton
2007-05-10 20:40 ` 2.6.21-mm2 Marc Dietrich
2007-05-11 8:27 ` [-mm patch] make csum_and_copy_from_user arch independent (was Re: 2.6.21-mm2) Frederik Deweerdt
2007-05-11 8:33 ` Andrew Morton
2007-05-11 9:14 ` [-mm patch] make csum_and_copy_from_user arch independent David Miller
2007-05-11 13:56 ` Frederik Deweerdt [this message]
2007-05-11 17:04 ` Russell King
2007-05-11 18:03 ` 2.6.21-mm2 boot failure, raid autodetect, bd_set_size+0xb/0x80 thunder7
2007-05-11 18:18 ` Andrew Morton
2007-05-11 18:53 ` thunder7
2007-05-15 3:25 ` 2.6.21-mm2 - CONFIG_STATISTIC and Intel PowerTOP Valdis.Kletnieks
2007-05-15 14:25 ` Martin Peschke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070511135618.GE23638@slug \
--to=deweerdt@free.fr \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox