From: Giel de Nijs <giel@caffeinetrip.com>
To: linux-kernel@vger.kernel.org
Cc: Vojtech Pavlik <vojtech@suse.cz>,
Dimitry Torokhov <dmitry.torokhov@gmail.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Matt Domsch <matt_domsch@dell.com>,
Rezwanul Kabir <rezwanul_kabir@dell.com>,
linux-input@atrey.karlin.mff.cuni.cz
Subject: [patch 1/2] input: add soft release key mask to keyboard driver
Date: Fri, 11 May 2007 19:23:27 +0200 [thread overview]
Message-ID: <20070511172441.343908560@caffeinetrip.com> (raw)
In-Reply-To: 20070511172326.008944330@caffeinetrip.com
[-- Attachment #1: add-keyboard-soft-release-mask.patch --]
[-- Type: text/plain, Size: 2485 bytes --]
Add keysrlmask to input_dev and add soft release handling in atkbd.c
Signed-off-by: Giel de Nijs <giel@caffeinetrip.com>
---
Index: linux-2.6.21.1/drivers/input/keyboard/atkbd.c
===================================================================
--- linux-2.6.21.1.orig/drivers/input/keyboard/atkbd.c 2007-05-10 18:34:48.000000000 +0200
+++ linux-2.6.21.1/drivers/input/keyboard/atkbd.c 2007-05-11 19:21:03.000000000 +0200
@@ -201,6 +201,7 @@
unsigned short id;
unsigned char keycode[512];
+ unsigned long keysrlmask[NBITS(512)];
unsigned char set;
unsigned char translated;
unsigned char extra;
@@ -412,14 +413,6 @@
"Some program might be trying access hardware directly.\n",
data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);
goto out;
- case ATKBD_RET_HANGEUL:
- case ATKBD_RET_HANJA:
- /*
- * These keys do not report release and thus need to be
- * flagged properly
- */
- add_release_event = 1;
- break;
case ATKBD_RET_ERR:
atkbd->err_count++;
#ifdef ATKBD_DEBUG
@@ -438,6 +431,9 @@
if (keycode != ATKBD_KEY_NULL)
input_event(dev, EV_MSC, MSC_SCAN, code);
+ if (test_bit(code, atkbd->keysrlmask))
+ add_release_event = 1;
+
switch (keycode) {
case ATKBD_KEY_NULL:
break;
@@ -832,6 +828,7 @@
int i, j;
memset(atkbd->keycode, 0, sizeof(atkbd->keycode));
+ bitmap_zero(atkbd->keysrlmask, 512);
if (atkbd->translated) {
for (i = 0; i < 128; i++) {
@@ -854,6 +851,11 @@
atkbd->keycode[atkbd_compat_scancode(atkbd, ATKBD_RET_HANGEUL)] = KEY_HANGUEL;
atkbd->keycode[atkbd_compat_scancode(atkbd, ATKBD_RET_HANJA)] = KEY_HANJA;
+
+ set_bit(atkbd_compat_scancode(atkbd, ATKBD_RET_HANGEUL),
+ atkbd->keysrlmask);
+ set_bit(atkbd_compat_scancode(atkbd, ATKBD_RET_HANJA),
+ atkbd->keysrlmask);
}
/*
@@ -911,6 +913,7 @@
}
input_dev->keycode = atkbd->keycode;
+ input_dev->keysrlmask = atkbd->keysrlmask;
input_dev->keycodesize = sizeof(unsigned char);
input_dev->keycodemax = ARRAY_SIZE(atkbd_set2_keycode);
Index: linux-2.6.21.1/include/linux/input.h
===================================================================
--- linux-2.6.21.1.orig/include/linux/input.h 2007-05-10 18:32:39.000000000 +0200
+++ linux-2.6.21.1/include/linux/input.h 2007-05-10 18:56:50.000000000 +0200
@@ -962,6 +962,7 @@
unsigned int keycodemax;
unsigned int keycodesize;
void *keycode;
+ unsigned long *keysrlmask; /* soft-release scancodes key mask */
struct ff_device *ff;
--
next prev parent reply other threads:[~2007-05-11 21:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 17:23 [patch 0/2] [PATCH] input: correctly handle keys without hardware release event Giel de Nijs
2007-05-11 17:23 ` Giel de Nijs [this message]
2007-05-11 17:23 ` [patch 2/2] input: add ioctls to console for soft release mask read/write Giel de Nijs
2007-05-14 3:44 ` [patch 0/2] [PATCH] input: correctly handle keys without hardware release event Dmitry Torokhov
2007-05-14 6:16 ` Giel de Nijs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070511172441.343908560@caffeinetrip.com \
--to=giel@caffeinetrip.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=matt_domsch@dell.com \
--cc=mjg59@srcf.ucam.org \
--cc=rezwanul_kabir@dell.com \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox