From: Paul Mundt <lethal@linux-sh.org>
To: clameter@sgi.com
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [patch 2/2] Slab allocators: Drop support for destructors
Date: Sat, 12 May 2007 10:33:25 +0900 [thread overview]
Message-ID: <20070512013325.GB27172@linux-sh.org> (raw)
In-Reply-To: <20070511165946.145806097@sgi.com>
On Fri, May 11, 2007 at 09:57:51AM -0700, clameter@sgi.com wrote:
> There is no user of destructors left. There is no reason why we should
> keep checking for destructors calls in the slab allocators.
>
> The RFC for this patch was discussed at
> http://marc.info/?l=linux-kernel&m=117882364330705&w=2
>
> Destructors were mainly used for list management which required them to take a
> spinlock. Taking a spinlock in a destructor is a bit risky since the slab
> allocators may run the destructors anytime they decide a slab is no longer
> needed.
>
> Patch drops destructor support. Any attempt to use a destructor will BUG().
>
> Cc: Pekka Enberg <penberg@cs.helsinki.fi>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
>
Acked-by: Paul Mundt <lethal@linux-sh.org>
prev parent reply other threads:[~2007-05-12 1:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 16:57 [patch 0/2] Remove destructor support from slab allocators clameter
2007-05-11 16:57 ` [patch 1/2] From: Paul Mundt <lethal@linux-sh.org> clameter
2007-05-11 18:39 ` Andrew Morton
2007-05-12 0:22 ` Christoph Lameter
2007-05-12 1:33 ` Paul Mundt
2007-05-12 1:41 ` Andrew Morton
2007-05-11 16:57 ` [patch 2/2] Slab allocators: Drop support for destructors clameter
2007-05-11 17:55 ` Pekka Enberg
2007-05-12 1:33 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070512013325.GB27172@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox