From: Andi Kleen <ak@suse.de>
To: Daniel Walker <dwalker@mvista.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
johnstul@us.ibm.com, mingo@elte.hu
Subject: Re: [PATCH 1/2] non-string based tsc unstable reasons
Date: Sat, 12 May 2007 20:56:42 +0200 [thread overview]
Message-ID: <200705122056.42926.ak@suse.de> (raw)
In-Reply-To: <20070512154344.395866578@mvista.com>
On Saturday 12 May 2007 17:43:45 Daniel Walker wrote:
> Just passing a string to mark_tsc_unstable() doesn't allow real code to change
> based on the reason for the instablility. I changed mark_tsc_unstable()
> to accept a string and a flag which denotes a general reason why the tsc
> is unstable, and can be evaluated in code.
>
> This is based off John Stultz patch to add the string reasons.
This seems ugly -- it would be better to just do whatever needs to
be doing in the caller instead of passing down a enum and then switch.
And why do you really need it anyways?
-Andi
next prev parent reply other threads:[~2007-05-12 18:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-12 15:43 [PATCH 1/2] non-string based tsc unstable reasons Daniel Walker
2007-05-12 15:43 ` [PATCH 2/2] i386: sched_clock() follows percpu frequency changes Daniel Walker
2007-05-12 18:58 ` Andi Kleen
2007-05-12 19:25 ` Daniel Walker
2007-05-12 18:56 ` Andi Kleen [this message]
2007-05-12 19:10 ` [PATCH 1/2] non-string based tsc unstable reasons Daniel Walker
-- strict thread matches above, loose matches on Subject: below --
2007-05-25 19:32 Daniel Walker
2007-05-25 21:05 ` Andi Kleen
2007-05-25 21:31 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705122056.42926.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dwalker@mvista.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox