Re: [PATCH 1/2] non-string based tsc unstable reasons

Daniel Walker
2007-05-12T19:13:06Z

On Sat, 2007-05-12 at 20:56 +0200, Andi Kleen wrote:
> On Saturday 12 May 2007 17:43:45 Daniel Walker wrote:
> > Just passing a string to mark_tsc_unstable() doesn't allow real code to change
> > based on the reason for the instablility. I changed mark_tsc_unstable()
> > to accept a string and a flag which denotes a general reason why the tsc
> > is unstable, and can be evaluated in code.
> >
> > This is based off John Stultz patch to add the string reasons.
>
> This seems ugly -- it would be better to just do whatever needs to
> be doing in the caller instead of passing down a enum and then switch.
>
> And why do you really need it anyways?

Sending the string in mark_tsc_unstable() is already in linus-git
AFAIK .. The enum is just to allow sched_clock to switch off the TSC in
some situations, and not all..

Daniel