From: Jens Axboe <jens.axboe@oracle.com>
To: Dmitry Torokhov <dtor@insightbb.com>
Cc: "Yin,Fengwei" <yfw.kernel@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: Is this a preempt issue in drivers/input/evdev.c
Date: Sun, 13 May 2007 20:12:27 +0200 [thread overview]
Message-ID: <20070513181225.GV4629@kernel.dk> (raw)
In-Reply-To: <200705120105.40699.dtor@insightbb.com>
On Sat, May 12 2007, Dmitry Torokhov wrote:
> Hi,
>
> On Friday 11 May 2007 23:18, Yin,Fengwei wrote:
> >
> > So if the evdev_release() is preempted at the point marked by another
> > process which will open the evdev, which will make operation sequence
> > like:
> >
> > --evdev->open in evdev_release()
> > -----> preempted
> > evdev->open++ and input_open_devie()
> > <----- reschedule
> > input_close_device()
> >
> > Should we introduce a mutex here? Or do I miss something? Thanks.
> >
>
> Locking is completely absent in evdev. There was a patch introducing
> locking in recent -mm's but it got dropped. I need to refresh it.
How did stuff like that ever get merged, btw? I still have a completely
trivially oopsable rmmod psmouse problem, I hope it'll get fixed for
2.6.22.
--
Jens Axboe
prev parent reply other threads:[~2007-05-13 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-12 3:18 Is this a preempt issue in drivers/input/evdev.c Yin,Fengwei
2007-05-12 5:05 ` Dmitry Torokhov
2007-05-13 18:12 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070513181225.GV4629@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=dtor@insightbb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yfw.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox