From: Oleg Nesterov <oleg@tv-sign.ru>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
Alex Dubov <oakad@yahoo.com>, Pierre Ossman <drzeus@drzeus.cx>
Subject: Re: 2.6.22-rc1: Broken suspend on SMP with tifm
Date: Mon, 14 May 2007 01:54:25 +0400 [thread overview]
Message-ID: <20070513215425.GA3240@tv-sign.ru> (raw)
In-Reply-To: <200705132350.32582.rjw@sisk.pl>
On 05/13, Rafael J. Wysocki wrote:
>
> On Sunday, 13 May 2007 23:34, Oleg Nesterov wrote:
> > On 05/13, Rafael J. Wysocki wrote:
> > >
> > > @@ -819,20 +843,31 @@ static int __devinit workqueue_cpu_callb
> > >
> > > +
> > > + case CPU_DEAD_FROZEN:
> > > + if (wq->freezeable) {
> > > + take_over_work(wq, cpu);
> > > + thaw_process(cwq->thread);
> >
> > Suppose that PF_NOFREEZE task T does flush_workqueue(), and CPU 1 has pending
> > works. T does flush_cpu_workqueue(0), CPU_DEAD_FROZEN moves works from CPU 1
> > to CPU 0, T does flush_cpu_workqueue(1) and finds nothing.
>
> I don't think this is possible, because we've acquired workqueue_mutex in
> _cpu_down().
Yes, we did... but flush_workqueue() doesn't take it?
Oleg.
next prev parent reply other threads:[~2007-05-13 21:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-13 19:32 2.6.22-rc1: Broken suspend on SMP with tifm Rafael J. Wysocki
2007-05-13 20:08 ` Oleg Nesterov
2007-05-13 20:30 ` Oleg Nesterov
2007-05-13 20:50 ` Rafael J. Wysocki
2007-05-13 20:50 ` Oleg Nesterov
2007-05-13 21:22 ` Rafael J. Wysocki
2007-05-13 21:34 ` Oleg Nesterov
2007-05-13 21:50 ` Rafael J. Wysocki
2007-05-13 21:54 ` Oleg Nesterov [this message]
2007-05-13 22:21 ` Rafael J. Wysocki
2007-05-13 22:32 ` Oleg Nesterov
2007-05-14 3:24 ` Alex Dubov
2007-05-14 5:57 ` Rafael J. Wysocki
2007-05-14 16:55 ` Freezeable workqueues [Was: 2.6.22-rc1: Broken suspend on SMP with tifm] Oleg Nesterov
2007-05-14 21:27 ` Rafael J. Wysocki
2007-05-14 21:48 ` Oleg Nesterov
2007-05-15 0:56 ` Alex Dubov
2007-05-15 20:54 ` Rafael J. Wysocki
2007-05-15 20:54 ` Rafael J. Wysocki
2007-05-20 19:54 ` Oleg Nesterov
2007-05-20 20:48 ` Rafael J. Wysocki
2007-05-20 21:06 ` Oleg Nesterov
2007-05-20 21:49 ` Rafael J. Wysocki
2007-05-13 20:33 ` 2.6.22-rc1: Broken suspend on SMP with tifm Rafael J. Wysocki
2007-05-13 21:52 ` [PATCH] for 2.6.22, make freezeable workqueues singlethread Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070513215425.GA3240@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=drzeus@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=oakad@yahoo.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox