Re: Linux 2.6.22-rc1

Roland Dreier
2007-05-13T23:32:17Z

> > Would it be asking too much to have help texts on the following
> > new (wrt 2.6.21) configuration options?
> >
> > ESP Scsi Driver Core (SCSI_ESP_CORE) [N/m] (NEW)
>
> This one is a case where the option makes no sense by itself,
> it provides the core common code for other front-end drivers.
>
> The documentation exists in those front end drivers, which
> in turn auto-matically select and enable this config option.
>
> It would be nice if there was a Kconfig way to not provide
> this thing at all unless one of the front-ends got selected
> but on the otherhand I like how anyone can select it and thus
> test the build of it :-)

If this is just an internal option that people shouldn't have to deal
with, why have a prompt at all? AFAIK the following (untested) patch
should do exactly what you want.

FWIW:
Signed-off-by: Roland Dreier <rolandd@cisco.com>

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index e62d23f..5366913 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -1754,7 +1754,7 @@ config SUN3X_ESP
machines. Say Y here to compile in support for it.

config SCSI_ESP_CORE
- tristate "ESP Scsi Driver Core"
+ tristate
depends on SCSI
select SCSI_SPI_ATTRS