Re: Linux 2.6.22-rc1

Tilman Schmidt
2007-05-14T21:37:34Z

[-- Attachment #1: Type: text/plain, Size: 2661 bytes --]

Am 14.05.2007 22:33 schrieb Jan Engelhardt:
> On May 14 2007 20:01, Tilman Schmidt wrote:
>>> "Patches welcome" ;-)
>> Sure. Just tell me exactly what those options are intended to do
>> and I'll happily write up a patch adding help texts trying to
>> express that in bad English. :-)
>
> They are just a menu that can be switched on or off.

Ok, that's the first essential piece of information which is *not*
evident from the prompt "make oldconfig" presents me with:

Ethernet (1000 Mbit) (NETDEV_1000) [Y/n] (NEW)

contains *no* indication that this is the start of a menu.

> * Disabling this menu disables all the fluff inside it,

Another essential piece of information. I seem to remember other
menus which, when disabled, kept the selection status of the
options inside and just hid them from view.

> menuconfig NETDEV_10000
> bool "Ethernet (10GbE)"
> ---help--
> Say Y here to actually be able to go into this menu
> and select some drivers that we think belong to the
> "10 Gigabit Ethernet" family.
>
> If unsure, it is unwise to say N!
>
> See, this looks so fundamentally basic to me that I find it
> almost funny. YMMV, hence I asked for suggestions from
> other people.

That's because it's so incomplete and mentions only the facts
which where obvious in the first place. (Except for the "this
menu" part which might appear rather cryptic to users of the
curses based interface who don't see any menu.)

Have a look at the entry "config NET_ETHERNET" for an impression
of what others felt worth mentioning in similar circumstances.
And no, that is not funny, even though much of it is of course
fundamentally basic for most of us. It does actually help people
confronted with the question.

>> For a start, it shouldn't require users to grep through Kconfigs
>> and Makefiles in order to find out what effects an option has.
>
> menuconfigs are some special kind in that they combine an option
> with a menu. Perhaps now that some ->menuconfig patches have gone
> in, more people will get to know these constructs.

Point is, without grepping through the Kconfig the user has no
way of knowing that the question comes from a menuconfig in the
first place, at least with "make menuconfig" and friends, and
without grepping through the Makefile (and, à la limite, source
files) s/he cannot be sure the option doesn't directly affect
code generation.

Thanks,
Tilman

--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 253 bytes --]