Re: [RFC][PATCH 10/14] In-kernel file copy between union mounted filesystems

Bharata B Rao
2007-05-22T03:07:53Z

On Fri, May 18, 2007 at 09:47:31AM -0400, Shaya Potter wrote:
> Bharata B Rao wrote:
>
> >
> >Not really. This is called during copyup of a file residing in a lower
> >layer. And that is done only for regular files.
>
> That is broken.

But it only breaks the semantics (in other cases we allow writes only to the
top layer files). So the question is why do we have to copy up the device
node ? What difference it makes to writing to the device itself ? Currently
we allow write to the device using the lower layer device node itself.

>
> You should be able to change the permissions on a device node on a layer
> that is RO.
>

Hmm not sure why we need to touch the permissions of the device. See below.

> so it would copy it up (1. mknod, 2. copy attributes) and then the
> appropriate attribute notification change would be called.

With union mount, when a regular file is opened for write, it is checked
if it resides in the lower layer and if so copied up to the topmost layer
and this new fd is returned from open. And any subsequent writes using this
fd will go to the newly created topmost file. (We are aware that we are not
yet copying the (extended) attributes to the newly created topmost file,
which we have to do).

Regards,
Bharata.