Re: [RFC][PATCH 14/14] tmpfs whiteout support

Jan Blunck
2007-05-14T19:21:07Z

On 5/14/07, Hugh Dickins <hugh@veritas.com> wrote:
> On Mon, 14 May 2007, Bharata B Rao wrote:
> > From: Jan Blunck <j.blunck@tu-harburg.de>
> > Subject: tmpfs whiteout support
> >
> > Introduce whiteout support to tmpfs.
> >
> > Signed-off-by: Jan Blunck <j.blunck@tu-harburg.de>
> > Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> > ---
> > mm/shmem.c | 9 ++++++++-
> > 1 files changed, 8 insertions(+), 1 deletion(-)
> >
> > --- a/mm/shmem.c
> > +++ b/mm/shmem.c
> > @@ -74,7 +74,7 @@
> > #define LATENCY_LIMIT 64
> >
> > /* Pretend that each entry is of this size in directory's i_size */
> > -#define BOGO_DIRENT_SIZE 20
> > +#define BOGO_DIRENT_SIZE 1
>
> Why would that change be needed for whiteout support?
>

Good question. It seems that this a survivor of the changes necessary
for union readdir. This isn't necessary for white-outs.

BTW: Why do we claim this to be 20??? Is there any meaning behind this?

Cheers,
Jan