* [PATCH] drivers/net/skfp/drvfbi.c: trivial cleanup
@ 2007-05-14 21:27 Frank Seidel
2007-05-15 6:34 ` AW: " Abdelkarim Jamal
0 siblings, 1 reply; 4+ messages in thread
From: Frank Seidel @ 2007-05-14 21:27 UTC (permalink / raw)
To: Linux Kernel; +Cc: linux
This patch (for 2.6.21-mm2) contains a trivial cleanup:
- removes unused exist_board() variation
- removed part is depecrated and doesn't compile anymore
Signed-off-by: Frank Seidel <frank@kernalert.de>
---
drivers/net/skfp/drvfbi.c | 40 ----------------------------------------
1 file changed, 40 deletions(-)
Index: b/drivers/net/skfp/drvfbi.c
===================================================================
--- a/drivers/net/skfp/drvfbi.c
+++ b/drivers/net/skfp/drvfbi.c
@@ -1224,46 +1224,6 @@ int get_board_para(struct s_smc *smc, in
}
#endif /* ISA */
-#ifdef PCI
-#ifdef USE_BIOS_FUN
-int exist_board(struct s_smc *smc, int slot)
-{
- u_short dev_id ;
- u_short ven_id ;
- int found ;
- int i ;
-
- found = FALSE ; /* make sure we returned with adatper not found*/
- /* if an empty oemids.h was included */
-
-#ifdef MULT_OEM
- smc->hw.oem_id = (struct s_oem_ids *) &oem_ids[0] ;
- for (; smc->hw.oem_id->oi_status != OI_STAT_LAST; smc->hw.oem_id++) {
- if (smc->hw.oem_id->oi_status < smc->hw.oem_min_status)
- continue ;
-#endif
- ven_id = OEMID(smc,0) + (OEMID(smc,1) << 8) ;
- dev_id = OEMID(smc,2) + (OEMID(smc,3) << 8) ;
- for (i = 0; i < slot; i++) {
- if (pci_find_device(i,&smc->hw.pci_handle,
- dev_id,ven_id) != 0) {
-
- found = FALSE ;
- } else {
- found = TRUE ;
- }
- }
- if (found) {
- return(1) ; /* adapter was found */
- }
-#ifdef MULT_OEM
- }
-#endif
- return(0) ; /* adapter was not found */
-}
-#endif /* PCI */
-#endif /* USE_BIOS_FUNC */
-
void driver_get_bia(struct s_smc *smc, struct fddi_addr *bia_addr)
{
int i ;
^ permalink raw reply [flat|nested] 4+ messages in thread* AW: [PATCH] drivers/net/skfp/drvfbi.c: trivial cleanup
2007-05-14 21:27 [PATCH] drivers/net/skfp/drvfbi.c: trivial cleanup Frank Seidel
@ 2007-05-15 6:34 ` Abdelkarim Jamal
2007-05-15 7:07 ` Frank Seidel
0 siblings, 1 reply; 4+ messages in thread
From: Abdelkarim Jamal @ 2007-05-15 6:34 UTC (permalink / raw)
To: Frank Seidel, Linux Kernel; +Cc: linux
Vielen Dank Herr Seidel fuer Ihr Feedback.
Mit freundlichen Gruessen
Jamal
Marvell® Semiconductor Germany GmbH
-------------------------------------
Dipl. -Ing. Karim Jamal
Technical Support Engineer
--------------------------------------
Phone: +49 (0) 7243502-330
Fax: +49 (0) 7243502-364
Mail: support@syskonnect.de
Web: http:\\www.syskonnect.de
Marvell Semiconductor Germany GmbH, Siemensstr. 23, 76275 Ettlingen, Amtsgericht Karlsruhe HRB 1620 E Geschäftsführer: Dipl.-Volksw. Mathias Horak, Thomas Ruf
-----Ursprüngliche Nachricht-----
Von: Frank Seidel [mailto:frank@kernalert.de]
Gesendet: Montag, 14. Mai 2007 23:28
An: Linux Kernel
Cc: linux@syskonnect.de
Betreff: [PATCH] drivers/net/skfp/drvfbi.c: trivial cleanup
This patch (for 2.6.21-mm2) contains a trivial cleanup:
- removes unused exist_board() variation
- removed part is depecrated and doesn't compile anymore
Signed-off-by: Frank Seidel <frank@kernalert.de>
---
drivers/net/skfp/drvfbi.c | 40 ----------------------------------------
1 file changed, 40 deletions(-)
Index: b/drivers/net/skfp/drvfbi.c ===================================================================
--- a/drivers/net/skfp/drvfbi.c
+++ b/drivers/net/skfp/drvfbi.c
@@ -1224,46 +1224,6 @@ int get_board_para(struct s_smc *smc, in }
#endif /* ISA */
-#ifdef PCI
-#ifdef USE_BIOS_FUN
-int exist_board(struct s_smc *smc, int slot)
-{
- u_short dev_id ;
- u_short ven_id ;
- int found ;
- int i ;
-
- found = FALSE ; /* make sure we returned with adatper not found*/
- /* if an empty oemids.h was included */
-
-#ifdef MULT_OEM
- smc->hw.oem_id = (struct s_oem_ids *) &oem_ids[0] ;
- for (; smc->hw.oem_id->oi_status != OI_STAT_LAST; smc->hw.oem_id++) {
- if (smc->hw.oem_id->oi_status < smc->hw.oem_min_status)
- continue ;
-#endif
- ven_id = OEMID(smc,0) + (OEMID(smc,1) << 8) ;
- dev_id = OEMID(smc,2) + (OEMID(smc,3) << 8) ;
- for (i = 0; i < slot; i++) {
- if (pci_find_device(i,&smc->hw.pci_handle,
- dev_id,ven_id) != 0) {
-
- found = FALSE ;
- } else {
- found = TRUE ;
- }
- }
- if (found) {
- return(1) ; /* adapter was found */
- }
-#ifdef MULT_OEM
- }
-#endif
- return(0) ; /* adapter was not found */
-}
-#endif /* PCI */
-#endif /* USE_BIOS_FUNC */
-
void driver_get_bia(struct s_smc *smc, struct fddi_addr *bia_addr) {
int i ;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: AW: [PATCH] drivers/net/skfp/drvfbi.c: trivial cleanup
2007-05-15 6:34 ` AW: " Abdelkarim Jamal
@ 2007-05-15 7:07 ` Frank Seidel
0 siblings, 0 replies; 4+ messages in thread
From: Frank Seidel @ 2007-05-15 7:07 UTC (permalink / raw)
To: Abdelkarim Jamal; +Cc: Linux Kernel, linux
On Tuesday 15 May 2007 08:34, Abdelkarim Jamal wrote:
> Vielen Dank Herr Seidel fuer Ihr Feedback.
>
> Mit freundlichen Gruessen
> Jamal
My pleasure! Just a small side note/question: On my first
mail i CCed Christoph Goos who is noted in skfddi.c to
be the maintainer,
but i finally received a failure notice containing
Remote host said: 550 5.2.1 <cgoos@syskonnect.de>... Mailbox disabled for this recipient
So, are you Mr. Goos' successor and to be contacted on
changes/suggestions for the skfp driver in the future?
Thanks,
Frank
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drivers/net/skfp/drvfbi.c: trivial cleanup
@ 2007-05-14 21:19 Frank Seidel
0 siblings, 0 replies; 4+ messages in thread
From: Frank Seidel @ 2007-05-14 21:19 UTC (permalink / raw)
To: Linux Kernel; +Cc: Christoph Goos
This patch (for 2.6.21-mm2) contains a trivial cleanup:
- removes unused exist_board() variation
- removed part is depecrated and doesn't compile anymore
Signed-off-by: Frank Seidel <frank@kernalert.de>
---
drivers/net/skfp/drvfbi.c | 40 ----------------------------------------
1 file changed, 40 deletions(-)
Index: b/drivers/net/skfp/drvfbi.c
===================================================================
--- a/drivers/net/skfp/drvfbi.c
+++ b/drivers/net/skfp/drvfbi.c
@@ -1224,46 +1224,6 @@ int get_board_para(struct s_smc *smc, in
}
#endif /* ISA */
-#ifdef PCI
-#ifdef USE_BIOS_FUN
-int exist_board(struct s_smc *smc, int slot)
-{
- u_short dev_id ;
- u_short ven_id ;
- int found ;
- int i ;
-
- found = FALSE ; /* make sure we returned with adatper not found*/
- /* if an empty oemids.h was included */
-
-#ifdef MULT_OEM
- smc->hw.oem_id = (struct s_oem_ids *) &oem_ids[0] ;
- for (; smc->hw.oem_id->oi_status != OI_STAT_LAST; smc->hw.oem_id++) {
- if (smc->hw.oem_id->oi_status < smc->hw.oem_min_status)
- continue ;
-#endif
- ven_id = OEMID(smc,0) + (OEMID(smc,1) << 8) ;
- dev_id = OEMID(smc,2) + (OEMID(smc,3) << 8) ;
- for (i = 0; i < slot; i++) {
- if (pci_find_device(i,&smc->hw.pci_handle,
- dev_id,ven_id) != 0) {
-
- found = FALSE ;
- } else {
- found = TRUE ;
- }
- }
- if (found) {
- return(1) ; /* adapter was found */
- }
-#ifdef MULT_OEM
- }
-#endif
- return(0) ; /* adapter was not found */
-}
-#endif /* PCI */
-#endif /* USE_BIOS_FUNC */
-
void driver_get_bia(struct s_smc *smc, struct fddi_addr *bia_addr)
{
int i ;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-05-15 7:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-14 21:27 [PATCH] drivers/net/skfp/drvfbi.c: trivial cleanup Frank Seidel
2007-05-15 6:34 ` AW: " Abdelkarim Jamal
2007-05-15 7:07 ` Frank Seidel
-- strict thread matches above, loose matches on Subject: below --
2007-05-14 21:19 Frank Seidel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox