Re: [PATCH] Add driver for Dallas DS1682 elapsed time recorder

[Jean Delvare <khali@linux-fr.org>]

Hi Andrew,

On Mon, 14 May 2007 23:34:01 -0700, Andrew Morton wrote:
> On Sun, 13 May 2007 01:43:42 -0600 Grant Likely <grant.likely@secretlab.ca> wrote:
> 
> > Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> > ---
> > 
> > Here is the 3rd iteration with the following changes:
> > - Modified to be an i2c "new style" driver based on David Brownell's work
> > - uses the new prototype for i2c_smbus_read_i2c_block_data() for block data
> >   reads instead of a single byte at a time.\
> 
> What new prototype for i2c_smbus_read_i2c_block_data()?
> 
> drivers/i2c/chips/ds1682.c: In function 'ds1682_show':
> drivers/i2c/chips/ds1682.c:75: warning: passing argument 3 of 'i2c_smbus_read_i2c_block_data' makes pointer from integer without a cast
> drivers/i2c/chips/ds1682.c:75: error: too many arguments to function 'i2c_smbus_read_i2c_block_data'
> drivers/i2c/chips/ds1682.c: In function 'ds1682_eeprom_read':
> drivers/i2c/chips/ds1682.c:165: warning: passing argument 3 of 'i2c_smbus_read_i2c_block_data' makes pointer from integer without a cast
> drivers/i2c/chips/ds1682.c:165: error: too many arguments to function 'i2c_smbus_read_i2c_block_data'

Please drop your version of the DS1682 patch, and refresh my
jdelvare-i2c quilt tree. You'll get the i2c_smbus_read_i2c_block_data
prototype update as well as the final version of Grant's DS1682 patch.

You would save yourself quite some work if you were waiting for i2c
patches to come to you through my tree. I am paying attention to the
dependencies, exactly in order to prevent problems like the one above.
Not to say I am not grateful when you collect important i2c fixes which
have been sent only to LKML and that I would otherwise have missed, but
in the case of the DS1682 patch, it was pretty visible that I was taking
care of it.

Thanks,
-- 
Jean Delvare