From: William Lee Irwin III <wli@holomorphy.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andi Kleen <ak@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <clameter@sgi.com>,
David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i386: don't check_pgt_cache in flush_tlb_mm
Date: Tue, 15 May 2007 11:59:47 -0700 [thread overview]
Message-ID: <20070515185947.GY19966@holomorphy.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0705151946550.30826@blonde.wat.veritas.com>
On Tue, May 15, 2007 at 07:51:05PM +0100, Hugh Dickins wrote:
> No other architecture calls check_pgt_cache() from within flush_tlb_mm(),
> and i386 is already calling check_pgt_cache() from the usual places,
> tlb_finish_mmu() and cpu_idle() (the latter being odd, but not unusual).
> flush_tlb_mm() has no business to be freeing pages: remove that line,
> which sneaked in with slub's i386 support.
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
Acked-by: William Irwin <bill.irwin@oracle.com>
-- wli
prev parent reply other threads:[~2007-05-15 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 18:51 [PATCH] i386: don't check_pgt_cache in flush_tlb_mm Hugh Dickins
2007-05-15 18:55 ` Christoph Lameter
2007-05-15 18:59 ` William Lee Irwin III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070515185947.GY19966@holomorphy.com \
--to=wli@holomorphy.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=davem@davemloft.net \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox