* [PATCH] i386: don't check_pgt_cache in flush_tlb_mm
@ 2007-05-15 18:51 Hugh Dickins
2007-05-15 18:55 ` Christoph Lameter
2007-05-15 18:59 ` William Lee Irwin III
0 siblings, 2 replies; 3+ messages in thread
From: Hugh Dickins @ 2007-05-15 18:51 UTC (permalink / raw)
To: Andi Kleen
Cc: Andrew Morton, Christoph Lameter, William Lee Irwin III,
David Miller, linux-kernel
No other architecture calls check_pgt_cache() from within flush_tlb_mm(),
and i386 is already calling check_pgt_cache() from the usual places,
tlb_finish_mmu() and cpu_idle() (the latter being odd, but not unusual).
flush_tlb_mm() has no business to be freeing pages: remove that line,
which sneaked in with slub's i386 support.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
arch/i386/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 2.6.22-rc1/arch/i386/kernel/smp.c 2007-05-13 05:40:51.000000000 +0100
+++ linux/arch/i386/kernel/smp.c 2007-05-15 17:49:48.000000000 +0100
@@ -421,7 +421,7 @@ void flush_tlb_mm (struct mm_struct * mm
}
if (!cpus_empty(cpu_mask))
flush_tlb_others(cpu_mask, mm, TLB_FLUSH_ALL);
- check_pgt_cache();
+
preempt_enable();
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i386: don't check_pgt_cache in flush_tlb_mm
2007-05-15 18:51 [PATCH] i386: don't check_pgt_cache in flush_tlb_mm Hugh Dickins
@ 2007-05-15 18:55 ` Christoph Lameter
2007-05-15 18:59 ` William Lee Irwin III
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Lameter @ 2007-05-15 18:55 UTC (permalink / raw)
To: Hugh Dickins
Cc: Andi Kleen, Andrew Morton, William Lee Irwin III, David Miller,
linux-kernel
Acked-by: Christoph Lameter <clameter@sgi.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i386: don't check_pgt_cache in flush_tlb_mm
2007-05-15 18:51 [PATCH] i386: don't check_pgt_cache in flush_tlb_mm Hugh Dickins
2007-05-15 18:55 ` Christoph Lameter
@ 2007-05-15 18:59 ` William Lee Irwin III
1 sibling, 0 replies; 3+ messages in thread
From: William Lee Irwin III @ 2007-05-15 18:59 UTC (permalink / raw)
To: Hugh Dickins
Cc: Andi Kleen, Andrew Morton, Christoph Lameter, David Miller,
linux-kernel
On Tue, May 15, 2007 at 07:51:05PM +0100, Hugh Dickins wrote:
> No other architecture calls check_pgt_cache() from within flush_tlb_mm(),
> and i386 is already calling check_pgt_cache() from the usual places,
> tlb_finish_mmu() and cpu_idle() (the latter being odd, but not unusual).
> flush_tlb_mm() has no business to be freeing pages: remove that line,
> which sneaked in with slub's i386 support.
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
Acked-by: William Irwin <bill.irwin@oracle.com>
-- wli
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-05-15 18:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-15 18:51 [PATCH] i386: don't check_pgt_cache in flush_tlb_mm Hugh Dickins
2007-05-15 18:55 ` Christoph Lameter
2007-05-15 18:59 ` William Lee Irwin III
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox