From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
zippel@linux-m68k.org, kbuild-devel@lists.sourceforge.net
Subject: Re: [RFC] select and dependencies in Kconfig
Date: Wed, 16 May 2007 09:38:55 +0100 [thread overview]
Message-ID: <20070516083855.GC15071@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20070516033335.GH4095@ftp.linux.org.uk>
On Wed, May 16, 2007 at 04:33:35AM +0100, Al Viro wrote:
> On Tue, May 15, 2007 at 08:36:20PM +0100, Al Viro wrote:
> >
> > stuff that does select USB should depend on USB_ARCH_HAS_HCD, or we'll
> > end up with unbuildable configs.
>
> BTW, this kind of situation happens often enough, so how about doing
> the following: teach kconfig that if FOO selects BAR and BAR depends
> on <expr>, we should act as if FOO had explicit depends on <expr>.
We first need to ensure that we don't have any cases which explore the
current behaviour. I wonder how the following will be interpreted with
the ARCH_IXP4XX=y and ARCH_IXP4XX=n cases:
arch/arm/common/Kconfig:config SA1111
arch/arm/common/Kconfig: bool
arch/arm/common/Kconfig: select DMABOUNCE
arch/arm/common/Kconfig:
arch/arm/common/Kconfig:config DMABOUNCE
arch/arm/common/Kconfig: bool
arch/arm/mach-ixp4xx/Kconfig:if ARCH_IXP4XX
arch/arm/mach-ixp4xx/Kconfig:
...
arch/arm/mach-ixp4xx/Kconfig:config DMABOUNCE
arch/arm/mach-ixp4xx/Kconfig- bool
arch/arm/mach-ixp4xx/Kconfig- default y
arch/arm/mach-ixp4xx/Kconfig- depends on PCI
...
arch/arm/mach-ixp4xx/Kconfig:endif
We also have:
arch/arm/mm/Kconfig:config CPU_32v6K
arch/arm/mm/Kconfig- bool "Support ARM V6K processor extensions" if !SMP
arch/arm/mm/Kconfig- depends on CPU_V6
arch/arm/mm/Kconfig- default y if SMP
which gives: option available on V6 CPUs, user selectable on V6 UP, always
selected on V6 SMP.
and:
arch/arm/mm/Kconfig:config CPU_V7
arch/arm/mm/Kconfig: bool "Support ARM V7 processor"
arch/arm/mm/Kconfig: depends on ARCH_INTEGRATOR
arch/arm/mm/Kconfig: select CPU_32v6K
It would be undesirable for CPU_V7 to depend on CPU_V6 being set. (V7
always has V6K.) I guess V6K would have to become:
config CPU_32v6K
bool "Support ARM V6K processor extensions" if !SMP && !CPU_V7
depends on CPU_V6 || CPU_V7
default y if SMP || CPU_V7
and the select statement removed from CPU_V7.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2007-05-16 8:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 19:36 [PATCH] missing dependencies for USB drivers in input Al Viro
2007-05-16 3:33 ` [RFC] select and dependencies in Kconfig Al Viro
2007-05-16 3:48 ` Linus Torvalds
2007-05-16 14:20 ` Satyam Sharma
2007-05-16 15:31 ` Satyam Sharma
2007-05-16 8:38 ` Russell King [this message]
2007-05-16 14:24 ` Stefan Richter
2007-05-16 23:30 ` Timur Tabi
2007-05-17 0:16 ` Stefan Richter
2007-05-17 0:32 ` Stefan Richter
2007-05-18 3:38 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070516083855.GC15071@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=kbuild-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox