From: Dave Jones <davej@redhat.com>
To: Joshua Hoblitt <jhoblitt@ifa.hawaii.edu>
Cc: Daniel Drake <dsd@gentoo.org>,
duaneg@dghda.com, prakash@punnoor.de,
linux-kernel@vger.kernel.org, Ed Sweetman <safemode2@comcast.net>,
mark.langsdorf@amd.com
Subject: Re: [PATCH] powernow-k8: depend on acpi-processor for SMP systems
Date: Wed, 16 May 2007 20:37:33 -0400 [thread overview]
Message-ID: <20070517003733.GD16810@redhat.com> (raw)
In-Reply-To: <20070517002614.GU15763@ifa.hawaii.edu>
On Wed, May 16, 2007 at 02:26:14PM -1000, Joshua Hoblitt wrote:
> I don't think this is quiet right either as Ed Sweetman has reported
> that this issue doesn't occur on single socket/multi-core systems.
I'm not sure why [*], because this should be preventing it..
if (num_online_cpus() != 1) {
printk(KERN_ERR PFX "MP systems not supported by PSB BIOS structure\n");
kfree(data);
return -ENODEV;
}
num_online_cpus will return 2 in a dual-core system, even though there's
just one socket. Given they share a power plane, if there's a valid
PSB structure however, it may be usable. Though this isn't necessarily
true for all future dual-core AMD CPUs, and the ACPI tables really
should be preferred.
Dave
[*] unless you have the second core disabled or CONFIG_SMP=n
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-05-17 0:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 23:50 [PATCH] powernow-k8: depend on acpi-processor for SMP systems Daniel Drake
2007-05-17 0:03 ` Dave Jones
2007-05-17 0:26 ` Joshua Hoblitt
2007-05-17 0:37 ` Dave Jones [this message]
2007-05-17 0:54 ` Daniel Drake
2007-05-17 1:03 ` Ed Sweetman
2007-05-17 9:02 ` Pavel Machek
2007-05-17 10:24 ` Ed Sweetman
2007-06-04 10:52 ` Pavel Machek
2007-05-17 18:13 ` Len Brown
2007-05-17 18:23 ` Dave Jones
2007-05-17 21:29 ` Ed Sweetman
2007-05-17 21:40 ` Ed Sweetman
2007-05-17 21:52 ` Dave Jones
2007-05-17 22:15 ` Ed Sweetman
2007-05-17 21:43 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070517003733.GD16810@redhat.com \
--to=davej@redhat.com \
--cc=dsd@gentoo.org \
--cc=duaneg@dghda.com \
--cc=jhoblitt@ifa.hawaii.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
--cc=prakash@punnoor.de \
--cc=safemode2@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox