From: Dave Jones <davej@redhat.com>
To: Len Brown <lenb@kernel.org>
Cc: Daniel Drake <dsd@gentoo.org>,
duaneg@dghda.com, prakash@punnoor.de, jhoblitt@ifa.hawaii.edu,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powernow-k8: depend on acpi-processor for SMP systems
Date: Thu, 17 May 2007 14:23:40 -0400 [thread overview]
Message-ID: <20070517182340.GA25691@redhat.com> (raw)
In-Reply-To: <200705171413.42595.lenb@kernel.org>
On Thu, May 17, 2007 at 02:13:42PM -0400, Len Brown wrote:
> > Index: linux/arch/i386/kernel/cpu/cpufreq/Kconfig
> > ===================================================================
> > --- linux.orig/arch/i386/kernel/cpu/cpufreq/Kconfig
> > +++ linux/arch/i386/kernel/cpu/cpufreq/Kconfig
> > @@ -81,6 +81,7 @@ config X86_POWERNOW_K7_ACPI
> > config X86_POWERNOW_K8
> > tristate "AMD Opteron/Athlon64 PowerNow!"
> > select CPU_FREQ_TABLE
> > + select ACPI_PROCESSOR if SMP
> > depends on EXPERIMENTAL
> > help
> > This adds the CPUFreq driver for mobile AMD Opteron/Athlon64 processors.
>
> Unfortunately this patch will not actually enable ACPI_PROCESSOR in
> the SMP=y ACPI=n case. "select" doesn't work for targets that
> have dependencies.
I don't think we can fix this perfectly tbh, but the above at
least gets us close for the majority of users.
Are there many x86-64 users that don't enable acpi ?
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-05-17 18:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 23:50 [PATCH] powernow-k8: depend on acpi-processor for SMP systems Daniel Drake
2007-05-17 0:03 ` Dave Jones
2007-05-17 0:26 ` Joshua Hoblitt
2007-05-17 0:37 ` Dave Jones
2007-05-17 0:54 ` Daniel Drake
2007-05-17 1:03 ` Ed Sweetman
2007-05-17 9:02 ` Pavel Machek
2007-05-17 10:24 ` Ed Sweetman
2007-06-04 10:52 ` Pavel Machek
2007-05-17 18:13 ` Len Brown
2007-05-17 18:23 ` Dave Jones [this message]
2007-05-17 21:29 ` Ed Sweetman
2007-05-17 21:40 ` Ed Sweetman
2007-05-17 21:52 ` Dave Jones
2007-05-17 22:15 ` Ed Sweetman
2007-05-17 21:43 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070517182340.GA25691@redhat.com \
--to=davej@redhat.com \
--cc=dsd@gentoo.org \
--cc=duaneg@dghda.com \
--cc=jhoblitt@ifa.hawaii.edu \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prakash@punnoor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox