From: Andi Kleen <ak@suse.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Stable Team <stable@kernel.org>, Greg KH <greg@kroah.com>,
Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
Ralf Baechle <ralf@linux-mips.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH] INPUT: Sanitize PIT locking in pcspkr
Date: Fri, 18 May 2007 06:27:00 +0200 [thread overview]
Message-ID: <200705180627.01224.ak@suse.de> (raw)
In-Reply-To: <1179413375.3764.86.camel@chaos>
On Thursday 17 May 2007 16:49, Thomas Gleixner wrote:
> Both read the PIT directly, which will lead to interesting results. The
> PIT is either stopped or it can be used in one shot mode with per event
> changing intervals due to the changes introduced by the clock events
> layer.
>
> This code should use ktime_get() and not fiddle in the hardware itself.
The gameport code also does TSC accesses directly which is similarly
broken. I remember complaining about that some time ago, but it never
got fixed in the end.
-Andi
next prev parent reply other threads:[~2007-05-18 4:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 13:36 [PATCH] INPUT: Sanitize PIT locking in pcspkr Thomas Gleixner
2007-05-17 14:15 ` Dmitry Torokhov
2007-05-17 14:35 ` Thomas Gleixner
2007-05-17 14:36 ` Dmitry Torokhov
2007-05-17 14:49 ` Thomas Gleixner
2007-05-18 4:27 ` Andi Kleen [this message]
2007-05-18 6:26 ` Dmitry Torokhov
2007-06-12 0:27 ` [stable] " Chris Wright
2007-06-12 5:50 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705180627.01224.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=dmitry.torokhov@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox