Re: [PATCH] Chaining sg lists for big IO commands v5

[Jens Axboe <jens.axboe@oracle.com>]

On Thu, May 17 2007, Badari Pulavarty wrote:
> On Thu, 2007-05-17 at 08:27 +0200, Jens Axboe wrote:
> .. 
> > > > 
> > > > Ah ok, you need the updated patch series for ppc64 support. Builds fine
> > > > here on ppc64. See the #sglist branch of the block repo:
> > > > 
> > > > git://git.kernel.dk/data/git/linux-2.6-block.git
> > > > 
> > > > I can mail you an updated patch, if you want.
> > > 
> > > 
> > > Here is the whole panic stack..
> > 
> > Thanks will fix that up, the IDE part is totally untested. Can you try
> > and backout this patch and see if it boots?
> 
> Yes. It boots fine with following backed out.
> 
> Looking at the code ide_probe.c: hwif_init() is doing
> 
>         hwif->sg_table = kmalloc(sizeof(struct scatterlist)*hwif->sg_max_nents,
>                                  GFP_KERNEL);
> 
> blk_rq_map_sg() is looking for the chaining info and going over end of the
> allocation.

Hmm, looks ok, I'm guessing it's just missing a memset (or just turn it
into a kzalloc())?

-- 
Jens Axboe