public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Char: cyclades, add firmware loading
Date: Fri, 18 May 2007 11:10:48 -0700	[thread overview]
Message-ID: <20070518111048.55e9d811.akpm@linux-foundation.org> (raw)
In-Reply-To: <2258930840122446564@wsc.cz>

On Fri, 18 May 2007 19:49:11 +0200 (CEST)
Jiri Slaby <jirislaby@gmail.com> wrote:

> cyclades, add firmware loading
> 

eww, it adds a variable called "tmp".

This change isn't appropriate to 2.6.22.

The second patch fixes a bug in 2.6.22-rc1 and in 2.6.21 (yes?) but
includes irrelevant changes which aren't appropriate to 2.6.22 and which
depend on patch #1.

So I split the bugfix out into a separate patch.

  parent reply	other threads:[~2007-05-18 18:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-18 17:49 [PATCH 1/2] Char: cyclades, add firmware loading Jiri Slaby
2007-05-18 17:49 ` [PATCH 2/2] Char: cyclades, fix sparse warning Jiri Slaby
2007-05-18 18:10 ` Andrew Morton [this message]
2007-05-18 18:47   ` [PATCH 1/2] Char: cyclades, add firmware loading Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070518111048.55e9d811.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox