From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] Misc: phantom, move to unlocked_ioctl
Date: Fri, 18 May 2007 14:03:14 -0700 [thread overview]
Message-ID: <20070518140314.4cabb926.akpm@linux-foundation.org> (raw)
In-Reply-To: <20644182862815412171@wsc.cz>
On Fri, 18 May 2007 22:34:53 +0200 (CEST)
Jiri Slaby <jirislaby@gmail.com> wrote:
> @@ -118,7 +125,9 @@ static int phantom_ioctl(struct inode *inode, struct file *file, u_int cmd,
> if (r.reg > 7)
> return -EINVAL;
>
> + spin_lock(&dev->ioctl_lock);
> r.value = ioread32(dev->iaddr + r.reg);
> + spin_unlock(&dev->ioctl_lock);
What is that locking protecting in here?
next prev parent reply other threads:[~2007-05-18 21:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-18 20:34 [PATCH 1/1] Misc: phantom, move to unlocked_ioctl Jiri Slaby
2007-05-18 21:03 ` Andrew Morton [this message]
2007-05-18 21:25 ` Jiri Slaby
2007-05-18 21:46 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070518140314.4cabb926.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox