Re: [PATCH 2/3] drm modesetting core

[Jesse Barnes <jesse.barnes@intel.com>]

On Friday, May 18, 2007 12:33 pm Luca Tettamanti wrote:
> > Yeah, there's more sharing that could be done... though I don't
> > think the fb layer has the bits to actually grab EDIDs.
>
> There are the I2C functions (fb_do_probe_ddc_edid, fb_ddc_read - I
> wrote them for the radeon driver, but now are available for general
> use) which will issue the read command; fbmon.c has the stuff for
> parsing the EDID; you usualy build a DB of supported modes which is
> then used to validate the mode requested by the user. Of course each
> driver has to implement the I2C adapter.

I'll take a look at fbmon... I've seen the fb_ddc_read stuff but didn't 
see many drivers using it heavily.  I think it makes sense to reuse 
your code where possible (in fact some earlier versions of the code 
made more use of FB stuff but was removed or rewritten for various 
reasons).

> > Also, DRM is shared with BSD...
>
> Your patch already uses 'struct i2c_adapter' in drm_edid.c, is it
> portable?

I'm not sure how portable that will be.  But regardless, if Linux has 
some of this code already, I'd like to reuse it.  I'll go head and see 
what I can rip out.

In fact, I've received some comments pushing me towards moving the core 
code (crtc, mode management) to drivers/video instead of DRM.  That 
might make sense, especially if we can just use/extend the FB layer's 
mode tracking structures.

Thanks,
Jesse