From: Sam Ravnborg <sam@ravnborg.org>
To: LKML <linux-kernel@vger.kernel.org>,
Roman Zippel <zippel@linux-m68k.org>
Subject: RFC: kconfig select warnings bogus?
Date: Sat, 19 May 2007 17:15:23 +0200 [thread overview]
Message-ID: <20070519151523.GA26724@uranus.ravnborg.org> (raw)
We see a lot of these lately:
GEN /home/bor/build/linux-2.6.22/Makefile
scripts/kconfig/conf -s arch/i386/Kconfig
drivers/macintosh/Kconfig:116:warning: 'select' used by config symbol 'PMAC_APM_EMU' refers to undefined symbol 'SYS_SUPPORTS_APM_EMULATION'
drivers/net/Kconfig:2283:warning: 'select' used by config symbol 'UCC_GETH' refers to undefined symbol 'UCC_FAST'
drivers/input/keyboard/Kconfig:170:warning: 'select' used by config symbol 'KEYBOARD_ATARI' refers to undefined symbol 'ATARI_KBD_CORE'
drivers/input/mouse/Kconfig:182:warning: 'select' used by config symbol 'MOUSE_ATARI' refers to undefined symbol 'ATARI_KBD_CORE'
Do this warning really add any value or should we just ignore them like this?
Sam
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index f14aeac..c0c84f2 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -200,11 +200,6 @@ void sym_check_prop(struct symbol *sym)
prop_warn(prop,
"config symbol '%s' uses select, but is "
"not boolean or tristate", sym->name);
- else if (sym2->type == S_UNKNOWN)
- prop_warn(prop,
- "'select' used by config symbol '%s' "
- "refers to undefined symbol '%s'",
- sym->name, sym2->name);
else if (sym2->type != S_BOOLEAN && sym2->type != S_TRISTATE)
prop_warn(prop,
"'%s' has wrong type. 'select' only "
next reply other threads:[~2007-05-19 15:14 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-19 15:15 Sam Ravnborg [this message]
2007-05-19 18:09 ` RFC: kconfig select warnings bogus? Andrew Morton
2007-05-19 22:17 ` Satyam Sharma
2007-05-19 22:49 ` Satyam Sharma
2007-05-19 23:09 ` Adrian Bunk
2007-05-19 23:17 ` Satyam Sharma
2007-05-19 23:25 ` Adrian Bunk
2007-05-19 23:36 ` Satyam Sharma
2007-05-19 23:41 ` Satyam Sharma
2007-05-19 23:51 ` Adrian Bunk
2007-05-20 0:02 ` Satyam Sharma
2007-05-19 23:48 ` Adrian Bunk
2007-05-19 23:55 ` Satyam Sharma
2007-05-20 0:13 ` Adrian Bunk
2007-05-20 0:19 ` Satyam Sharma
2007-05-20 9:52 ` Trent Piepho
2007-05-20 10:58 ` Stefan Richter
2007-05-20 11:23 ` Trent Piepho
2007-05-20 11:44 ` Stefan Richter
2007-05-20 19:57 ` Trent Piepho
2007-05-20 20:12 ` Stefan Richter
2007-05-20 20:41 ` Trent Piepho
2007-05-22 15:13 ` Satyam Sharma
2007-05-20 18:30 ` Adrian Bunk
2007-05-20 0:46 ` Stefan Richter
2007-05-20 0:53 ` Satyam Sharma
2007-05-20 1:04 ` Satyam Sharma
2007-05-20 8:31 ` Stefan Richter
2007-05-20 11:38 ` Satyam Sharma
2007-05-20 11:47 ` Stefan Richter
2007-05-20 11:57 ` Satyam Sharma
2007-05-20 13:09 ` Stefan Richter
2007-05-20 13:50 ` Satyam Sharma
2007-05-20 14:39 ` Stefan Richter
2007-05-22 14:53 ` Satyam Sharma
2007-05-22 17:03 ` Stefan Richter
2007-05-22 17:13 ` Satyam Sharma
2007-05-22 17:38 ` Stefan Richter
2007-05-22 17:46 ` Satyam Sharma
2007-05-22 17:54 ` Stefan Richter
2007-05-22 17:59 ` Satyam Sharma
2007-05-20 18:23 ` Adrian Bunk
2007-05-19 23:05 ` Adrian Bunk
2007-05-19 23:17 ` Satyam Sharma
2007-05-19 23:21 ` Satyam Sharma
2007-05-19 23:29 ` Adrian Bunk
2007-05-19 23:32 ` Satyam Sharma
2007-05-19 23:23 ` Adrian Bunk
2007-05-19 23:22 ` Andrew Morton
2007-05-20 0:02 ` Adrian Bunk
2007-05-20 0:11 ` Satyam Sharma
2007-05-20 9:43 ` Russell King
2007-05-20 9:40 ` Russell King
2007-05-20 10:17 ` Sam Ravnborg
2007-05-20 11:07 ` Geert Uytterhoeven
2007-05-21 0:25 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070519151523.GA26724@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox