Re: RFC: kconfig select warnings bogus?

Adrian Bunk
2007-05-19T23:05:57Z

On Sat, May 19, 2007 at 11:09:44AM -0700, Andrew Morton wrote:
> On Sat, 19 May 2007 17:15:23 +0200 Sam Ravnborg <sam@ravnborg.org> wrote:
>
> > We see a lot of these lately:
> > GEN /home/bor/build/linux-2.6.22/Makefile
> > scripts/kconfig/conf -s arch/i386/Kconfig
> > drivers/macintosh/Kconfig:116:warning: 'select' used by config symbol 'PMAC_APM_EMU' refers to undefined symbol 'SYS_SUPPORTS_APM_EMULATION'
> > drivers/net/Kconfig:2283:warning: 'select' used by config symbol 'UCC_GETH' refers to undefined symbol 'UCC_FAST'
> > drivers/input/keyboard/Kconfig:170:warning: 'select' used by config symbol 'KEYBOARD_ATARI' refers to undefined symbol 'ATARI_KBD_CORE'
> > drivers/input/mouse/Kconfig:182:warning: 'select' used by config symbol 'MOUSE_ATARI' refers to undefined symbol 'ATARI_KBD_CORE'
> >
> >
> > Do this warning really add any value or should we just ignore them like this?
> >
>
> They always indicate Kconfig bugs, don't they? If so, we should keep the
> warning.
>...

No, they aren't always.

Look for example at the last one in drivers/input/mouse/Kconfig:

config MOUSE_ATARI
tristate "Atari mouse"
depends on ATARI
select ATARI_KBD_CORE

This is perfectly correct (the select'ed symbol is only unavailable when
the dependency can't be fulfilled), and all things to "fix" the warning
will make it worse.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed