From: Arnd Bergmann <arnd@arndb.de>
To: Petr Vandrovec <petr@vandrovec.name>
Cc: dan@dennedy.org, stefanr@s5r6.in-berlin.de,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code
Date: Sun, 20 May 2007 01:55:25 +0200 [thread overview]
Message-ID: <200705200155.26825.arnd@arndb.de> (raw)
In-Reply-To: <20070507021447.GA22197@vana.vc.cvut.cz>
On Monday 07 May 2007, Petr Vandrovec wrote:
> +struct raw1394_cycle_timer32 {
> + __u32 cycle_timer;
> + __u64 local_time;
> +} __attribute__((packed));
Note that this data structure only needs conversion on x86_64 and ia64, but
not on powerpc and other 64 bit architectures that align __u64 also in
32 bit mode.
I would suggest you introduce a new __compat_u64 type as
typedef __u64 __compat_u64 __attribute__((aligned(4)));
in include/asm-{x86_64,ia64}/compat.h and as
typdef __u64 __compat_u64;
in the other architectures. Other people have hit the same problem
before and found varying workarounds, but I think we should just
do it correctly now.
Arnd <><
next prev parent reply other threads:[~2007-05-19 23:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 2:14 [PATCH] Fix/add raw1394 CONFIG_COMPAT code Petr Vandrovec
2007-05-07 16:40 ` Stefan Richter
2007-05-15 3:52 ` Dan Dennedy
2007-05-15 22:59 ` Stefan Richter
2007-05-15 23:00 ` [PATCH 1/3] ieee1394: raw1394: Fix read() for 32bit userland on 64bit kernel Stefan Richter
2007-05-15 23:01 ` [PATCH 2/3] ieee1394: raw1394: Fix write() " Stefan Richter
2007-05-15 23:02 ` [PATCH 3/3] ieee1394: raw1394: Add ioctl() " Stefan Richter
2007-05-15 23:51 ` [PATCH] Fix/add raw1394 CONFIG_COMPAT code Petr Vandrovec
2007-05-19 23:55 ` Arnd Bergmann [this message]
2007-05-20 0:02 ` Stefan Richter
2007-05-20 15:03 ` Arnd Bergmann
2007-05-20 15:28 ` Stefan Richter
2007-05-20 15:37 ` Arnd Bergmann
2007-05-20 15:55 ` Stefan Richter
2007-05-21 7:28 ` Stefan Richter
2007-05-21 16:52 ` [PATCH] ieee1394: raw1394: Add ioctl() for 32bit userland on 64bit kernel, amendment Stefan Richter
2007-05-23 4:54 ` [PATCH] Fix/add raw1394 CONFIG_COMPAT code Dan Dennedy
2007-05-23 6:32 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705200155.26825.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=dan@dennedy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=petr@vandrovec.name \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox